refactor(linter/plugins): move LintFileReturnValue struct to above wrap_lint_file#16457
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 3, 2025
Conversation
github-actions
bot
added
A-cli
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
overlookmotel
force-pushed
the
12-03-perf_linter_plugins_move_result-processing_work_off_main_js_thread
branch
from
d81c9ca to
10cbdbf
Compare
overlookmotel
force-pushed
the
12-03-refactor_linter_plugins_move_lintfilereturnvalue_struct_to_above_wrap_lint_file_
branch
2 times, most recently
from
ac73de7 to
7563199
Compare
overlookmotel
force-pushed
the
12-03-perf_linter_plugins_move_result-processing_work_off_main_js_thread
branch
2 times, most recently
from
7b4c3e7 to
fe167bb
Compare
overlookmotel
force-pushed
the
12-03-refactor_linter_plugins_move_lintfilereturnvalue_struct_to_above_wrap_lint_file_
branch
from
7563199 to
3330bb1
Compare
This was referenced Dec 3, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs a pure refactor by relocating the LintFileReturnValue enum definition to immediately precede the wrap_lint_file function that uses it, improving code organization and readability.
Key Changes:
- Moved
LintFileReturnValueenum from afterwrap_load_pluginto beforewrap_lint_file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
camc314
approved these changes
Dec 3, 2025
overlookmotel
force-pushed
the
12-03-perf_linter_plugins_move_result-processing_work_off_main_js_thread
branch
from
fe167bb to
a9024d6
Compare
overlookmotel
force-pushed
the
12-03-refactor_linter_plugins_move_lintfilereturnvalue_struct_to_above_wrap_lint_file_
branch
from
3330bb1 to
9992bac
Compare
This was referenced Dec 3, 2025
Contributor
Merge activity
|
…`wrap_lint_file` (#16457) Pure refactor. Move this struct to above the function which uses it.
graphite-app
bot
force-pushed
the
12-03-perf_linter_plugins_move_result-processing_work_off_main_js_thread
branch
from
a9024d6 to
793b989
Compare
graphite-app
bot
force-pushed
the
12-03-refactor_linter_plugins_move_lintfilereturnvalue_struct_to_above_wrap_lint_file_
branch
from
9992bac to
34dacba
Compare
Base automatically changed from
12-03-perf_linter_plugins_move_result-processing_work_off_main_js_thread
to
main
December 3, 2025 19:14
graphite-app
bot
deleted the
12-03-refactor_linter_plugins_move_lintfilereturnvalue_struct_to_above_wrap_lint_file_
branch
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…`wrap_lint_file` (oxc-project#16457) Pure refactor. Move this struct to above the function which uses it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor. Move this struct to above the function which uses it.