Skip to content

style(editors): prefer const to let #16395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Dec 2, 2025
Merged

style(editors): prefer const to let #16395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion editors/vscode/client/ConfigService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export class ConfigService implements IDisposable {

if (!path.isAbsolute(bin)) {
// if the path is not absolute, resolve it to the first workspace folder
let cwd = this.workspaceConfigs.keys().next().value;
const cwd = this.workspaceConfigs.keys().next().value;
if (!cwd) {
return;
}
Expand Down
2 changes: 1 addition & 1 deletion editors/vscode/client/tools/linter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ export default class LinterTool implements ToolInterface {
// If the extension is launched in debug mode then the debug server options are used
// Otherwise the run options are used
// Options to control the language client
let clientOptions: LanguageClientOptions = {
const clientOptions: LanguageClientOptions = {
// Register the server for plain text documents
documentSelector: [
{
Expand Down
4 changes: 2 additions & 2 deletions editors/vscode/tests/ConfigService.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ suite('ConfigService', () => {
await conf.update('path.server', './relative/oxc_language_server');
const relativeServerPath = service.getUserServerBinPath();

let workspace_path = getWorkspaceFolderPlatformSafe();
const workspace_path = getWorkspaceFolderPlatformSafe();
strictEqual(relativeServerPath, `${workspace_path}/relative/oxc_language_server`);
});

Expand All @@ -63,7 +63,7 @@ suite('ConfigService', () => {
const service = new ConfigService();
await conf.update('path.server', './relative/oxc_language_server');
const relativeServerPath = service.getUserServerBinPath();
let workspace_path = getWorkspaceFolderPlatformSafe();
const workspace_path = getWorkspaceFolderPlatformSafe();

strictEqual(workspace_path[1], ':', 'The test workspace folder must be an absolute path with a drive letter on Windows');
strictEqual(relativeServerPath, `${workspace_path}\\relative\\oxc_language_server`);
Expand Down
8 changes: 4 additions & 4 deletions editors/vscode/tests/code_actions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ suite('code actions', () => {

// https://github.com/oxc-project/oxc/issues/10422
test('code action `source.fixAll.oxc` on editor.codeActionsOnSave', async () => {
let file = Uri.joinPath(fixturesWorkspaceUri(), 'fixtures', 'file.js');
let expectedFile = Uri.joinPath(fixturesWorkspaceUri(), 'fixtures', 'expected.txt');
const file = Uri.joinPath(fixturesWorkspaceUri(), 'fixtures', 'file.js');
const expectedFile = Uri.joinPath(fixturesWorkspaceUri(), 'fixtures', 'expected.txt');

await workspace.getConfiguration('editor').update('codeActionsOnSave', {
'source.fixAll.oxc': 'always',
Expand Down Expand Up @@ -112,8 +112,8 @@ suite('code actions', () => {

// https://discord.com/channels/1079625926024900739/1080723403595591700/1422191300395929620
test('code action `source.fixAll.oxc` ignores "ignore this rule for this line/file"', async () => {
let file = Uri.joinPath(fixturesWorkspaceUri(), 'fixtures', 'file2.js');
let expectedFile = Uri.joinPath(fixturesWorkspaceUri(), 'fixtures', 'expected.txt');
const file = Uri.joinPath(fixturesWorkspaceUri(), 'fixtures', 'file2.js');
const expectedFile = Uri.joinPath(fixturesWorkspaceUri(), 'fixtures', 'expected.txt');

await workspace.getConfiguration('editor').update('codeActionsOnSave', {
'source.fixAll.oxc': 'always',
Expand Down
Loading