style(editors): prefer const to let

[overlookmotel]

Use const where variables are not reassigned instead of let. Preparation for enabling ESLint's prefer-const rule (running as an Oxlint JS plugin) in our linting setup.

[overlookmotel]

• style(editors): prefer const to let #16395 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[overlookmotel]

I think this is uncontroversial, but editors is not my area, so I don't want to merge myself.

[Copilot]

Pull request overview

This PR updates variable declarations from let to const for variables that are never reassigned, in preparation for enabling ESLint's prefer-const rule. The changes improve code clarity by explicitly indicating immutability.

Key changes:

• Updated test files to use const for file path variables that are never reassigned
• Changed clientOptions declaration in linter tool to use const
• Updated path resolution variable to use const in ConfigService

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
editors/vscode/tests/code_actions.spec.ts	Changed file and expectedFile variables to const in two test cases
editors/vscode/tests/ConfigService.spec.ts	Changed workspace_path variable to const in two test cases
editors/vscode/client/tools/linter.ts	Changed clientOptions object declaration to const
editors/vscode/client/ConfigService.ts	Changed cwd variable to const in path resolution logic

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[camc314]

Merge activity

• Dec 2, 2:21 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 2, 2:25 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Dec 2, 2:30 PM UTC: Merged by the Graphite merge queue.

[connorshea]

Preparation for enabling ESLint's prefer-const rule (running as an Oxlint JS plugin) in our linting setup.

Alternatively.... #15707

[overlookmotel]

Preparation for enabling ESLint's prefer-const rule (running as an Oxlint JS plugin) in our linting setup.

Alternatively.... #15707

Oh great! I do like this rule!

However, part of the purpose is also to test out JS plugins. Once your Rust implementation is merged, I'll find another ESLint rule to use for this purpose.