fix(parser): forbid invalid modifiers on `module` and `global` by overlookmotel · Pull Request #15723 · oxc-project/oxc

overlookmotel · 2025-11-15T15:33:24Z

Error on invalid modifiers before module and global declarations.

Previously illegal syntax like this would be parsed without error:

protected accessor readonly async declare global {}
protected accessor readonly async global {}
protected accessor readonly async module "foo" {}

Discovered this bug while working on #15712.

Similar to #11713.

overlookmotel · 2025-11-15T15:33:43Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-11-15T15:38:33Z

CodSpeed Performance Report

Merging #15723 will not alter performance

_{Comparing 11-15-fix_parser_forbid_invalid_modifiers_on_module_and_global_ (4e1248e) with main (c167dfa)}

Summary

✅ 37 untouched

Copilot

Pull Request Overview

This PR adds validation to forbid invalid modifiers on module and global declarations in TypeScript. Previously, illegal syntax with multiple modifiers (like protected accessor readonly async declare global {}) would be parsed without error.

Adds verify_modifiers calls to validate that only the declare modifier is allowed on module and global declarations
Ensures consistency with similar validation done for other TypeScript declarations (enums, type aliases, interfaces)

Reviewed Changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File	Description
crates/oxc_parser/src/ts/statement.rs	Adds modifier validation for `parse_ambient_external_module_declaration`, `parse_module_or_namespace_declaration`, and `parse_ts_global_declaration` functions to reject invalid modifiers
tasks/coverage/snapshots/parser_typescript.snap	Updates test snapshots to reflect new error messages for invalid `export` modifier on module declarations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Boshen · 2025-11-18T01:54:02Z

Merge activity

Nov 18, 1:54 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Nov 18, 1:54 AM UTC: Boshen added this pull request to the Graphite merge queue.
Nov 18, 2:00 AM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Conformance').
Nov 18, 11:42 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Nov 18, 11:49 AM UTC: camc314 added this pull request to the Graphite merge queue.
Nov 18, 11:49 AM UTC: Merged by the Graphite merge queue.

Error on invalid modifiers before `module` and `global` declarations. Previously illegal syntax like this would be parsed without error: ```ts protected accessor readonly async declare global {} protected accessor readonly async global {} protected accessor readonly async module "foo" {} ``` Discovered this bug while working on #15712. Similar to #11713.

@license

### 💥 BREAKING CHANGES - cbb27fd ast: [**BREAKING**] Add `TSGlobalDeclaration` type (#15712) (overlookmotel) ### 🚀 Features - 0c1f82b linter/plugins: Add `tokens` property to `Program` (#16020) (overlookmotel) - 6cff132 span: Add `Span::merge_within` method (#15869) (sapphi-red) - 102365d allocator/vec: Add `Vec::into_bump_slice` method (#15770) (Dunqing) ### 🐛 Bug Fixes - e2ca770 codegen: Add support for printing type arguments in new expressions (#15963) (Ives van Hoorne) - 2bd3cb6 apps, editors, napi: Fix `oxlint-disable` comments (#16014) (overlookmotel) - 622cb5e parser: Preserve legal comments with @preserve/@license when preceded by other annotations (#15929) (copilot-swe-agent) - 7c46a9e transformer/tagged-template-transform: Handle `\n` escape sequences (#15830) (Dunqing) - f386efc minifier: Avoid generating invalid spans (#15778) (sapphi-red) - d4ff004 parser: Forbid invalid modifiers on `module` and `global` (#15723) (overlookmotel) - 2191ae9 semantic: Allow reserved keywords in typescript ambient contexts (#15495) (sapphi-red) - 7d1ebad isolated-declarations: Incorrect nested namespace output in isolated declarations (#15800) (copilot-swe-agent) ### ⚡ Performance - b4b0ed8 transformer/typescript: Reverse order of checks (#15722) (overlookmotel) ### 📚 Documentation - c81a331 data_structures: Doc comments on fields of `Stack` (#15793) (overlookmotel) - cfae31d allocator: Use `allocator` as var name in examples (#15781) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

…roject#15723) Error on invalid modifiers before `module` and `global` declarations. Previously illegal syntax like this would be parsed without error: ```ts protected accessor readonly async declare global {} protected accessor readonly async global {} protected accessor readonly async module "foo" {} ``` Discovered this bug while working on oxc-project#15712. Similar to oxc-project#11713.

@license

### 💥 BREAKING CHANGES - cbb27fd ast: [**BREAKING**] Add `TSGlobalDeclaration` type (oxc-project#15712) (overlookmotel) ### 🚀 Features - 0c1f82b linter/plugins: Add `tokens` property to `Program` (oxc-project#16020) (overlookmotel) - 6cff132 span: Add `Span::merge_within` method (oxc-project#15869) (sapphi-red) - 102365d allocator/vec: Add `Vec::into_bump_slice` method (oxc-project#15770) (Dunqing) ### 🐛 Bug Fixes - e2ca770 codegen: Add support for printing type arguments in new expressions (oxc-project#15963) (Ives van Hoorne) - 2bd3cb6 apps, editors, napi: Fix `oxlint-disable` comments (oxc-project#16014) (overlookmotel) - 622cb5e parser: Preserve legal comments with @preserve/@license when preceded by other annotations (oxc-project#15929) (copilot-swe-agent) - 7c46a9e transformer/tagged-template-transform: Handle `\n` escape sequences (oxc-project#15830) (Dunqing) - f386efc minifier: Avoid generating invalid spans (oxc-project#15778) (sapphi-red) - d4ff004 parser: Forbid invalid modifiers on `module` and `global` (oxc-project#15723) (overlookmotel) - 2191ae9 semantic: Allow reserved keywords in typescript ambient contexts (oxc-project#15495) (sapphi-red) - 7d1ebad isolated-declarations: Incorrect nested namespace output in isolated declarations (oxc-project#15800) (copilot-swe-agent) ### ⚡ Performance - b4b0ed8 transformer/typescript: Reverse order of checks (oxc-project#15722) (overlookmotel) ### 📚 Documentation - c81a331 data_structures: Doc comments on fields of `Stack` (oxc-project#15793) (overlookmotel) - cfae31d allocator: Use `allocator` as var name in examples (oxc-project#15781) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

github-actions bot added A-parser Area - Parser C-bug Category - Bug labels Nov 15, 2025

overlookmotel mentioned this pull request Nov 15, 2025

perf(transformer/typescript): reverse order of checks #15722

Merged

overlookmotel marked this pull request as ready for review November 15, 2025 15:34

overlookmotel self-assigned this Nov 15, 2025

overlookmotel requested a review from Boshen November 17, 2025 17:37

overlookmotel assigned Boshen and unassigned overlookmotel Nov 17, 2025

overlookmotel force-pushed the 11-15-fix_parser_forbid_invalid_modifiers_on_module_and_global_ branch from 3d430d9 to 522810e Compare November 17, 2025 18:17

overlookmotel force-pushed the 11-15-perf_transformer_typescript_reverse_order_of_checks branch from 74572d3 to 6b4cdae Compare November 17, 2025 18:17

graphite-app bot changed the base branch from 11-15-perf_transformer_typescript_reverse_order_of_checks to graphite-base/15723 November 17, 2025 19:26

graphite-app bot force-pushed the graphite-base/15723 branch from 6b4cdae to cbb27fd Compare November 17, 2025 19:31

graphite-app bot requested a review from Dunqing as a code owner November 17, 2025 19:31

graphite-app bot force-pushed the 11-15-fix_parser_forbid_invalid_modifiers_on_module_and_global_ branch from 522810e to 6fcc1a5 Compare November 17, 2025 19:31

github-actions bot added the A-transformer Area - Transformer / Transpiler label Nov 17, 2025

graphite-app bot changed the base branch from graphite-base/15723 to main November 17, 2025 19:31

graphite-app bot force-pushed the 11-15-fix_parser_forbid_invalid_modifiers_on_module_and_global_ branch 2 times, most recently from 3f085e4 to 8523f78 Compare November 17, 2025 19:35

Copilot AI review requested due to automatic review settings November 17, 2025 19:55

overlookmotel force-pushed the 11-15-fix_parser_forbid_invalid_modifiers_on_module_and_global_ branch from 8523f78 to 4e1248e Compare November 17, 2025 19:55

Copilot started reviewing on behalf of overlookmotel November 17, 2025 19:55 View session

Copilot finished reviewing on behalf of overlookmotel November 17, 2025 19:57

Copilot AI reviewed Nov 17, 2025

View reviewed changes

Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 18, 2025

graphite-app bot force-pushed the 11-15-fix_parser_forbid_invalid_modifiers_on_module_and_global_ branch from 4e1248e to 6f597bd Compare November 18, 2025 01:54

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 18, 2025

camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 18, 2025

camc314 force-pushed the 11-15-fix_parser_forbid_invalid_modifiers_on_module_and_global_ branch from 6f597bd to d4ff004 Compare November 18, 2025 11:43

graphite-app bot merged commit d4ff004 into main Nov 18, 2025
22 checks passed

graphite-app bot deleted the 11-15-fix_parser_forbid_invalid_modifiers_on_module_and_global_ branch November 18, 2025 11:49

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 18, 2025

Boshen mentioned this pull request Nov 24, 2025

release(crates): oxc v0.99.0 #16037

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

fix(parser): forbid invalid modifiers on `module` and `global`#15723

fix(parser): forbid invalid modifiers on `module` and `global`#15723
graphite-app[bot] merged 1 commit intomainfrom
11-15-fix_parser_forbid_invalid_modifiers_on_module_and_global_

overlookmotel commented Nov 15, 2025 •

edited

Loading

Uh oh!

overlookmotel commented Nov 15, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Nov 15, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Boshen commented Nov 18, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Comments

Conversation

overlookmotel commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #15723 will not alter performance

Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Boshen commented Nov 18, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

overlookmotel commented Nov 15, 2025 •

edited

Loading

overlookmotel commented Nov 15, 2025 •

edited

Loading

codspeed-hq bot commented Nov 15, 2025 •

edited

Loading

Boshen commented Nov 18, 2025 •

edited by graphite-app bot

Loading