perf(transformer/typescript): reverse order of checks by overlookmotel · Pull Request #15722 · oxc-project/oxc

overlookmotel · 2025-11-15T15:20:27Z

Tiny perf optimization. It's cheaper to check declare property once you know the type of the Declaration. Declaration::declare has to branch on the type of the Declaration.

overlookmotel · 2025-11-15T15:20:43Z

fix(parser): forbid invalid modifiers on module and global #15723
perf(transformer/typescript): reverse order of checks #15722 👈 (View in Graphite)
fix(ast)!: add TSGlobalDeclaration type #15712 : 1 other dependent PR (#15720 )
refactor(transformer/typescript): use exhaustive match #15711
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-11-15T15:25:03Z

CodSpeed Performance Report

Merging #15722 will not alter performance

_{Comparing 11-15-perf_transformer_typescript_reverse_order_of_checks (6b4cdae) with main (32f4fdd)¹}

Summary

✅ 33 untouched
⏩ 4 skipped²

No successful run was found on 11-06-fix_ast_add_tsglobaldeclaration_type (3fee43e) during the generation of this report, so main (32f4fdd) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

overlookmotel · 2025-11-17T17:36:54Z

Merge activity

Nov 17, 5:36 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Nov 17, 6:11 PM UTC: graphite-app added this pull request to the Graphite merge queue.
Nov 17, 6:11 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #15712.
Nov 17, 6:11 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #15712.
Nov 17, 7:25 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Nov 17, 7:25 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
Nov 17, 7:34 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Nov 17, 7:34 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
Nov 17, 7:35 PM UTC: Merged by the Graphite merge queue.

Tiny perf optimization. It's cheaper to check `declare` property once you know the type of the `Declaration`. `Declaration::declare` has to branch on the type of the `Declaration`.

@license

### 💥 BREAKING CHANGES - cbb27fd ast: [**BREAKING**] Add `TSGlobalDeclaration` type (#15712) (overlookmotel) ### 🚀 Features - 0c1f82b linter/plugins: Add `tokens` property to `Program` (#16020) (overlookmotel) - 6cff132 span: Add `Span::merge_within` method (#15869) (sapphi-red) - 102365d allocator/vec: Add `Vec::into_bump_slice` method (#15770) (Dunqing) ### 🐛 Bug Fixes - e2ca770 codegen: Add support for printing type arguments in new expressions (#15963) (Ives van Hoorne) - 2bd3cb6 apps, editors, napi: Fix `oxlint-disable` comments (#16014) (overlookmotel) - 622cb5e parser: Preserve legal comments with @preserve/@license when preceded by other annotations (#15929) (copilot-swe-agent) - 7c46a9e transformer/tagged-template-transform: Handle `\n` escape sequences (#15830) (Dunqing) - f386efc minifier: Avoid generating invalid spans (#15778) (sapphi-red) - d4ff004 parser: Forbid invalid modifiers on `module` and `global` (#15723) (overlookmotel) - 2191ae9 semantic: Allow reserved keywords in typescript ambient contexts (#15495) (sapphi-red) - 7d1ebad isolated-declarations: Incorrect nested namespace output in isolated declarations (#15800) (copilot-swe-agent) ### ⚡ Performance - b4b0ed8 transformer/typescript: Reverse order of checks (#15722) (overlookmotel) ### 📚 Documentation - c81a331 data_structures: Doc comments on fields of `Stack` (#15793) (overlookmotel) - cfae31d allocator: Use `allocator` as var name in examples (#15781) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

) Tiny perf optimization. It's cheaper to check `declare` property once you know the type of the `Declaration`. `Declaration::declare` has to branch on the type of the `Declaration`.

@license

### 💥 BREAKING CHANGES - cbb27fd ast: [**BREAKING**] Add `TSGlobalDeclaration` type (oxc-project#15712) (overlookmotel) ### 🚀 Features - 0c1f82b linter/plugins: Add `tokens` property to `Program` (oxc-project#16020) (overlookmotel) - 6cff132 span: Add `Span::merge_within` method (oxc-project#15869) (sapphi-red) - 102365d allocator/vec: Add `Vec::into_bump_slice` method (oxc-project#15770) (Dunqing) ### 🐛 Bug Fixes - e2ca770 codegen: Add support for printing type arguments in new expressions (oxc-project#15963) (Ives van Hoorne) - 2bd3cb6 apps, editors, napi: Fix `oxlint-disable` comments (oxc-project#16014) (overlookmotel) - 622cb5e parser: Preserve legal comments with @preserve/@license when preceded by other annotations (oxc-project#15929) (copilot-swe-agent) - 7c46a9e transformer/tagged-template-transform: Handle `\n` escape sequences (oxc-project#15830) (Dunqing) - f386efc minifier: Avoid generating invalid spans (oxc-project#15778) (sapphi-red) - d4ff004 parser: Forbid invalid modifiers on `module` and `global` (oxc-project#15723) (overlookmotel) - 2191ae9 semantic: Allow reserved keywords in typescript ambient contexts (oxc-project#15495) (sapphi-red) - 7d1ebad isolated-declarations: Incorrect nested namespace output in isolated declarations (oxc-project#15800) (copilot-swe-agent) ### ⚡ Performance - b4b0ed8 transformer/typescript: Reverse order of checks (oxc-project#15722) (overlookmotel) ### 📚 Documentation - c81a331 data_structures: Doc comments on fields of `Stack` (oxc-project#15793) (overlookmotel) - cfae31d allocator: Use `allocator` as var name in examples (oxc-project#15781) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

overlookmotel mentioned this pull request Nov 15, 2025

fix(ast)!: add TSGlobalDeclaration type #15712

Merged

github-actions bot added the A-transformer Area - Transformer / Transpiler label Nov 15, 2025

github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Nov 15, 2025

This was referenced Nov 15, 2025

refactor(transformer/typescript): use exhaustive match #15711

Merged

feat(parser): improve error message for missing namespace/module names #15720

Closed

overlookmotel marked this pull request as ready for review November 15, 2025 15:22

overlookmotel requested a review from Dunqing as a code owner November 15, 2025 15:22

overlookmotel mentioned this pull request Nov 15, 2025

fix(parser): forbid invalid modifiers on module and global #15723

Merged

overlookmotel assigned Dunqing Nov 15, 2025

Dunqing approved these changes Nov 17, 2025

View reviewed changes

overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 17, 2025

graphite-app bot changed the base branch from 11-06-fix_ast_add_tsglobaldeclaration_type to graphite-base/15722 November 17, 2025 17:37

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 17, 2025

overlookmotel force-pushed the 11-15-perf_transformer_typescript_reverse_order_of_checks branch from 74572d3 to 6b4cdae Compare November 17, 2025 18:17

overlookmotel force-pushed the graphite-base/15722 branch from 3f85660 to 3fee43e Compare November 17, 2025 18:17

overlookmotel changed the base branch from graphite-base/15722 to 11-06-fix_ast_add_tsglobaldeclaration_type November 17, 2025 18:17

overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 17, 2025

perf(transformer/typescript): reverse order of checks (#15722)

b4b0ed8

Tiny perf optimization. It's cheaper to check `declare` property once you know the type of the `Declaration`. `Declaration::declare` has to branch on the type of the `Declaration`.

graphite-app bot force-pushed the 11-06-fix_ast_add_tsglobaldeclaration_type branch from 3fee43e to cbb27fd Compare November 17, 2025 19:25

graphite-app bot requested a review from camc314 as a code owner November 17, 2025 19:25

graphite-app bot force-pushed the 11-15-perf_transformer_typescript_reverse_order_of_checks branch from 6b4cdae to b4b0ed8 Compare November 17, 2025 19:26

Base automatically changed from 11-06-fix_ast_add_tsglobaldeclaration_type to main November 17, 2025 19:30

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 17, 2025

overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 17, 2025

graphite-app bot merged commit b4b0ed8 into main Nov 17, 2025
21 checks passed

graphite-app bot deleted the 11-15-perf_transformer_typescript_reverse_order_of_checks branch November 17, 2025 19:35

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 17, 2025

Boshen mentioned this pull request Nov 24, 2025

release(crates): oxc v0.99.0 #16037

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

perf(transformer/typescript): reverse order of checks#15722

perf(transformer/typescript): reverse order of checks#15722
graphite-app[bot] merged 1 commit intomainfrom
11-15-perf_transformer_typescript_reverse_order_of_checks

overlookmotel commented Nov 15, 2025 •

edited

Loading

Uh oh!

overlookmotel commented Nov 15, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Nov 15, 2025 •

edited

Loading

Uh oh!

overlookmotel commented Nov 17, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Comments

Conversation

overlookmotel commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #15722 will not alter performance

Summary

Footnotes

Uh oh!

overlookmotel commented Nov 17, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

overlookmotel commented Nov 15, 2025 •

edited

Loading

overlookmotel commented Nov 15, 2025 •

edited

Loading

codspeed-hq bot commented Nov 15, 2025 •

edited

Loading

overlookmotel commented Nov 17, 2025 •

edited by graphite-app bot

Loading