Skip to content

fix(linter/no-var): incorrect warning for blocks #15504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camc314 merged 1 commit into from
Nov 9, 2025
Merged

fix(linter/no-var): incorrect warning for blocks #15504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion crates/oxc_linter/src/rules/eslint/no_var.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,15 @@ impl Rule for NoVar {
if let AstKind::VariableDeclaration(dec) = node.kind()
&& dec.kind == VariableDeclarationKind::Var
{
// Skip TypeScript ambient declarations (declare global/module/namespace)
if ctx
.nodes()
.ancestors(node.id())
.any(|ancestor| matches!(ancestor.kind(), AstKind::TSModuleDeclaration(module) if module.declare || module.kind.is_global()))
{
return;
}

let is_written_to = dec.declarations.iter().any(|v| is_written_to(&v.id, ctx));
let var_offset = ctx.find_next_token_from(dec.span.start, "var").unwrap();
let var_start = dec.span.start + var_offset;
Expand Down Expand Up @@ -119,7 +128,13 @@ fn is_written_to(binding_pat: &BindingPattern, ctx: &LintContext) -> bool {
fn test() {
use crate::tester::Tester;

let pass = vec![("const JOE = 'schmoe';", None), ("let moo = 'car';", None)];
let pass = vec![
("let moo = 'car';", None),
("const JOE = 'schmoe';", None),
("declare module 'testModule' { var x: string; }", None),
("declare namespace MyNamespace { var y: number; }", None),
("declare global { var __TEST_DECLARE_GLOBAL__: boolean | undefined; }", None),
];

let fail = vec![
("var foo = bar;", None),
Expand Down
Loading