fix(linter/no-var): incorrect warning for blocks

[hamirmahal]

Fixes #15503

[graphite-app]

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

[Copilot]

Pull Request Overview

This PR adds support for skipping TypeScript ambient declarations in the no_var linter rule. The rule previously flagged var declarations inside declare global, declare module, and declare namespace blocks, which are valid TypeScript constructs for type declarations.

Key changes:

• Added ancestor check to skip var declarations within TypeScript ambient module/namespace/global declarations
• Added test cases to verify the new behavior

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codspeed-hq]

CodSpeed Performance Report

Merging #15504 will not alter performance

_{Comparing hamirmahal:fix/linter/no-var/incorrect-warning (1be0188) with main (eeed5de)¹}

Summary

✅ 4 untouched
⏩ 33 skipped²

Footnotes

1. No successful run was found on main (37a44d0) during the generation of this report, so eeed5de was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[camc314]

Thank you!

I feel like i'm imagining things, i swear i already fixed this before 😆

[hamirmahal]

You're welcome! We merged a similar change for linter/vars-on-top.

[camc314]

Aha that's what it was. thank you!

[hamirmahal]

You're welcome!