Skip to content

docs(linter/no-this-before-super): correct "Why is this bad?" section#15408

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-07-docs_linter_no-this-before-super_correct_why_is_this_bad_section
Nov 7, 2025
Merged

docs(linter/no-this-before-super): correct "Why is this bad?" section#15408
graphite-app[bot] merged 1 commit intomainfrom
11-07-docs_linter_no-this-before-super_correct_why_is_this_bad_section

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 7, 2025

The description was of "eslint/getter-return" instead.

@github-actions github-actions bot added A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation labels Nov 7, 2025
Copy link
Member Author

sapphi-red commented Nov 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 7, 2025

CodSpeed Performance Report

Merging #15408 will not alter performance

Comparing 11-07-docs_linter_no-this-before-super_correct_why_is_this_bad_section (fdfc5d1) with main (2515045)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (57f0ce1) during the generation of this report, so 2515045 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sapphi-red sapphi-red force-pushed the 11-07-docs_linter_no-this-before-super_correct_why_is_this_bad_section branch from 2e084d8 to fdfc5d1 Compare November 7, 2025 05:08
@sapphi-red sapphi-red changed the base branch from graphite-base/15408 to 11-07-docs_linter_add_backquotes_where_appropriate November 7, 2025 05:08
Base automatically changed from 11-07-docs_linter_add_backquotes_where_appropriate to main November 7, 2025 05:09
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 7, 2025
Copy link
Contributor

camc314 commented Nov 7, 2025

Merge activity

…#15408)

The description was of "eslint/getter-return" instead.
Copilot AI review requested due to automatic review settings November 7, 2025 10:07
@graphite-app graphite-app bot force-pushed the 11-07-docs_linter_no-this-before-super_correct_why_is_this_bad_section branch from fdfc5d1 to 2ad77fb Compare November 7, 2025 10:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot merged commit 2ad77fb into main Nov 7, 2025
20 checks passed
@graphite-app graphite-app bot deleted the 11-07-docs_linter_no-this-before-super_correct_why_is_this_bad_section branch November 7, 2025 10:12
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments