Skip to content

docs(linter): add backquotes where appropriate#15407

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-07-docs_linter_add_backquotes_where_appropriate
Nov 7, 2025
Merged

docs(linter): add backquotes where appropriate#15407
graphite-app[bot] merged 1 commit intomainfrom
11-07-docs_linter_add_backquotes_where_appropriate

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 7, 2025

Added backquotes where appropriate.

@github-actions github-actions bot added the A-linter Area - Linter label Nov 7, 2025
Copy link
Member Author

sapphi-red commented Nov 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-docs Category - Documentation. Related to user-facing or internal documentation label Nov 7, 2025
@sapphi-red sapphi-red self-assigned this Nov 7, 2025
@sapphi-red sapphi-red marked this pull request as ready for review November 7, 2025 05:00
@sapphi-red sapphi-red requested a review from camc314 as a code owner November 7, 2025 05:00
Copilot AI review requested due to automatic review settings November 7, 2025 05:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances documentation formatting across multiple ESLint rule files by adding backticks around code elements for improved readability and consistency.

  • Adds backticks to function names, operators, and code expressions in documentation comments
  • Improves visual distinction between code and descriptive text
  • Maintains consistent formatting style across rule documentation

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
crates/oxc_linter/src/rules/eslint/use_isnan.rs Adds backticks around isNaN(), Number.isNaN(), and NaN comparison expressions
crates/oxc_linter/src/rules/eslint/no_unsafe_optional_chaining.rs Adds backticks around the optional chaining operator ?.
crates/oxc_linter/src/rules/eslint/no_extra_boolean_cast.rs Adds backticks around !! operator and Boolean function name
crates/oxc_linter/src/rules/eslint/no_compare_neg_zero.rs Adds backticks around -0, +0, code expressions, and Object.is()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 7, 2025

Merge activity

Added backquotes where appropriate.
@graphite-app graphite-app bot force-pushed the 11-07-docs_linter_add_backquotes_where_appropriate branch from 0bcbab5 to 57f0ce1 Compare November 7, 2025 05:05
@graphite-app graphite-app bot merged commit 57f0ce1 into main Nov 7, 2025
20 checks passed
@graphite-app graphite-app bot deleted the 11-07-docs_linter_add_backquotes_where_appropriate branch November 7, 2025 05:09
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 7, 2025

CodSpeed Performance Report

Merging #15407 will not alter performance

Comparing 11-07-docs_linter_add_backquotes_where_appropriate (57f0ce1) with main (2515045)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (57f0ce1) during the generation of this report, so 2515045 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments