perf(formatter): memorize text width for FormatElement::Text#15372
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 7, 2025
Merged
Conversation
github-actions
bot
added
the
C-performance
This was referenced Nov 6, 2025
Member
Author
CodSpeed Performance ReportMerging #15372 will improve performances by 10.12%Comparing Summary
Benchmarks breakdown
Footnotes
|
Dunqing
changed the title
FormatElemetn::TextFormatElement::Text
Dunqing
changed the title
FormatElement::TextFormatElement::Text
Dunqing
force-pushed
the
11-06-perf_formatter_memoize_text_width_for_formatelemetn_text
branch
from
92465a1 to
2b15086
Compare
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
11-06-feat_formatter_remove_tag_startverbatim_and_tag_endverbatim
branch
from
35201d9 to
2dfc3bd
Compare
graphite-app
bot
force-pushed
the
11-06-perf_formatter_memoize_text_width_for_formatelemetn_text
branch
from
2b15086 to
8f25a0e
Compare
graphite-app
bot
added
0-merge
Base automatically changed from
11-06-feat_formatter_remove_tag_startverbatim_and_tag_endverbatim
to
main
November 7, 2025 01:58
graphite-app
bot
deleted the
11-06-perf_formatter_memoize_text_width_for_formatelemetn_text
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Nov 7, 2025
…s based on its width (#15405) I forgot to change this in #15372 <img width="1291" height="386" alt="image" src="https://github.com/user-attachments/assets/db7c21f2-81e4-433a-8dae-a69813528af8" />
graphite-app bot
pushed a commit
that referenced
this pull request
Nov 17, 2025
…15762) Regressed by #15372. The changes are made to match previous behavior. In `fits_text`, once the text width is multiple lines, we should check whether the current line width plus the width of the text to the first line break is greater than the allowed line width to take action, but previously, we didn't include `plus the width of the text to the first line break`.
6 tasks
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…xc-project#15762) Regressed by oxc-project#15372. The changes are made to match previous behavior. In `fits_text`, once the text width is multiple lines, we should check whether the current line width plus the width of the text to the first line break is greater than the allowed line width to take action, but previously, we didn't include `plus the width of the text to the first line break`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back port from astral-sh/ruff#6552