Skip to content

feat(formatter): remove Tag::StartVerbatim and Tag::EndVerbatim#15370

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-06-feat_formatter_remove_tag_startverbatim_and_tag_endverbatim
Nov 7, 2025
Merged

feat(formatter): remove Tag::StartVerbatim and Tag::EndVerbatim#15370
graphite-app[bot] merged 1 commit intomainfrom
11-06-feat_formatter_remove_tag_startverbatim_and_tag_endverbatim

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Nov 6, 2025

No usage for this. From my understanding, this is used to handle invalid syntax, but our AST always produces a valid AST, so it is useless

Copy link
Member Author

Dunqing commented Nov 6, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 6, 2025

CodSpeed Performance Report

Merging #15370 will not alter performance

Comparing 11-06-feat_formatter_remove_tag_startverbatim_and_tag_endverbatim (35201d9) with 11-06-feat_formatter_remove_formatelement_locatedtokentext (cd23bd6)

Summary

✅ 33 untouched
⏩ 4 skipped1

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 7, 2025

Merge activity

…15370)

No usage for this. From my understanding, this is used to handle invalid syntax, but our AST always produces a valid AST, so it is useless
@graphite-app graphite-app bot force-pushed the 11-06-feat_formatter_remove_formatelement_locatedtokentext branch from cd23bd6 to 88c7530 Compare November 7, 2025 01:20
@graphite-app graphite-app bot force-pushed the 11-06-feat_formatter_remove_tag_startverbatim_and_tag_endverbatim branch from 35201d9 to 2dfc3bd Compare November 7, 2025 01:21
@graphite-app graphite-app bot added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Nov 7, 2025
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Nov 7, 2025
Base automatically changed from 11-06-feat_formatter_remove_formatelement_locatedtokentext to main November 7, 2025 01:58
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 7, 2025
@graphite-app graphite-app bot merged commit 2dfc3bd into main Nov 7, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 11-06-feat_formatter_remove_tag_startverbatim_and_tag_endverbatim branch November 7, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant