fix(formatter): improve handling of dangling comments in if statements by Dunqing · Pull Request #14658 · oxc-project/oxc

Dunqing · 2025-10-16T08:11:30Z

No description provided.

Dunqing · 2025-10-16T08:11:56Z

fix(formatter): incorrect handling of ObjectPattern as a parameter #14670
fix(formatter): correct checking assignment layout for the right side with ownline comment and it is a PrivateFieldExpression #14664
fix(formatter): should not merge tail with head for MemberChain when its parent is ArrowFunctionExpression #14663
fix(formatter): should not indent BinaryLikeExpression when its parent is NewExpression #14662
fix(formatter): should group nested test for TSConditionalType #14661
fix(formatter): correct handling if a template literal should be printed as a signle line #14660
fix(formatter): should group type parameters and parameters for method-like and function-like nodes #14659
fix(formatter): improve handling of dangling comments in if statements #14658 👈 (View in Graphite)
fix(formatter): don't print CallExpression as MemberChain style when its only has one argument and it is a TemplateLiteral on its own line #14657
fix(formatter): don't group nested await expression when its is the leftmost expression #14656
fix(formatter): correct checking function composition when the arguments have an call expression before function #14655
fix(formatter): don't wrap parenthesis for type when its grandparent isn't a ExpressionStatement #14654
fix(formatter): skip the leading semicolon when calculating leading lines #14653
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-10-16T08:20:07Z

CodSpeed Performance Report

Merging #14658 will degrade performances by 3.91%

_{Comparing 10-16-fix_formatter_improve_handling_of_dangling_comments_in_if_statements (8c67314) with main (a9d50a7)¹}

Summary

❌ 1 regression
✅ 32 untouched
⏩ 4 skipped²

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Mode	Benchmark	`BASE`	`HEAD`	Change
❌	Instrumentation	`minifier[cal.com.tsx]`	35.5 ms	36.9 ms	-3.91%

No successful run was found on 10-16-fix_formatter_don_t_print_callexpression_as_memberchain_style_when_its_only_has_one_argument_and_it_is_a_templateliteral_on_its_own_line (6039089) during the generation of this report, so main (a9d50a7) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

graphite-app · 2025-10-16T21:49:17Z

Merge activity

Oct 16, 9:49 PM UTC: leaysgur added this pull request to the Graphite merge queue.
Oct 16, 10:03 PM UTC: Merged by the Graphite merge queue.

#14658)

## [0.6.0] - 2025-10-20 ### 🚀 Features - 7f91a26 oxfmt: Handle ignoring files (#14798) (leaysgur) - 199a2c6 oxfmt: Support `--with-node-modules` option (#14713) (leaysgur) - 6bf8bac formatter: Reimplement formatting for `ImportExpression` (#14712) (Dunqing) - 3f2e036 formatter: Introduce `AstNode<ExpressionStatement>::is_arrow_function_body` (#14709) (Dunqing) - df225e9 formatter: Add `AstNode::ancestor` and `AstNode::grand_parent` methods (#14700) (Dunqing) - 26c5f5a oxfmt: Ignore VCS directories by default (#14616) (leaysgur) - fec2ed9 oxfmt: Use Prettier style config key and value (#14612) (leaysgur) - 1b58521 oxfmt,language_server: Enable JSX for all JS source type (#14605) (leaysgur) ### 🐛 Bug Fixes - 21c4285 formatter: Correct printing remaining trailing comments for `TSMappedType` (#14761) (Dunqing) - 1d1573e formatter: Correct adding semicolons for TypeScript left-hand side nodes (#14760) (Dunqing) - 4cc3b10 formatter: Improve handling of new lines between comments in `MemberChain` (#14759) (Dunqing) - e6bce8e formatter: Break the left hand side of AssignmentLike node if it is an `ObjectPattern` with three properties (#14756) (Dunqing) - dc57a2b formatter: Incorrect handling of `VariableDeclarator` with an `ArrowFunctionExpression` initializer (#14731) (Dunqing) - 537185d formatter: Should always group the left side of `AssignmentPattern` (#14730) (Dunqing) - ef02760 oxfmt: Handle relative path starts with dot (#14708) (leaysgur) - ee37f5d oxfmt: Handle default cwd correctly (#14704) (leaysgur) - 4283fd8 formatter: Correct printing comments for `JSXAttributeValue` (#14719) (Dunqing) - 59c9e1b formatter: Avoid conditional being broken in arguments by trailing comments (#14718) (Dunqing) - 7d64b96 formatter: Should wrap parentheses with JSX arguments of `NewExpression` (#14717) (Dunqing) - 2068a63 formatter: Should indent TemplateExpression if it is a member expression that is part of `ChainExpression` (#14714) (Dunqing) - 5ea3bb6 formatter: Incorrect handling of `ObjectPattern` as an `AssignmentPattern` of a parameter (#14711) (Dunqing) - eb52529 formatter: Incorrect handling of `ObjectPattern` as a parameter (#14670) (Dunqing) - 8ac10da formatter: Correct checking assignment layout for the right side with ownline comment and it is a `PrivateFieldExpression` (#14664) (Dunqing) - 6cba9b1 formatter: Should not merge tail with head for MemberChain when its parent is ArrowFunctionExpression (#14663) (Dunqing) - f44d3c0 formatter: Should not indent BinaryLikeExpression when its parent is `NewExpression` (#14662) (Dunqing) - bf953b8 formatter: Should group nested test for TSConditionalType (#14661) (Dunqing) - 63dc57b formatter: Correct handling if a template literal should be printed as a signle line (#14660) (Dunqing) - 0150ad5 formatter: Should group type parameters and parameters for method-like and function-like nodes (#14659) (Dunqing) - 392bf74 formatter: Improve handling of dangling comments in if statements (#14658) (Dunqing) - fd52b10 formatter: Don't print CallExpression as MemberChain style when its only has one argument and it is a TemplateLiteral on its own line (#14657) (Dunqing) - 29c3c60 formatter: Don't group nested await expression when its is the leftmost expression (#14656) (Dunqing) - 72c7503 formatter: Correct checking function composition when the arguments have an call expression before function (#14655) (Dunqing) - 2b645e2 formatter: Don't wrap parenthesis for `type` when its grandparent isn't a `ExpressionStatement` (#14654) (Dunqing) - e0eb966 formatter: Skip the leading semicolon when calculating leading lines (#14653) (Dunqing) - 0961c3a oxlint,oxfmt: Skip traversing `.git` directories (#14590) (Boshen) ### 🚜 Refactor - b7926f3 oxfmt: Update CLI --help details (#14796) (leaysgur) - 173168b oxfmt: Refactor walk.rs and format.rs relationship (#14795) (leaysgur) - aea9d79 oxfmt: Pass `PathBuf` from walk.rs to service.rs (#14716) (leaysgur) - 83e783a formatter: Organize utils structure (#14710) (Dunqing) - 58dd74a formatter: Remove all `without_parentheses` usages (#14707) (Dunqing) - 75dfcad formatter: Simplify `ExpressionLeftSide` (#14706) (Dunqing) - 273f0fe formatter: Remove unnecessary lifetimes for the implementations of `NeedsParentheses` (#14703) (Dunqing) - bae5f11 formatter: Improve `AstNode` and `AstNodes` (#14686) (Dunqing) ### ⚡ Performance - c6395c7 formatter: Optimize string reservation in print_text (#14751) (Boshen) ### 🧪 Testing - 7c42ea0 oxfmt: Remove args from snapshot file name (#14800) (leaysgur) - 42d8c62 formatter: Add tests for sort-imports (#14685) (leaysgur)

Dunqing mentioned this pull request Oct 16, 2025

fix(formatter): don't print CallExpression as MemberChain style when its only has one argument and it is a TemplateLiteral on its own line #14657

Merged

github-actions bot added A-formatter Area - Formatter C-bug Category - Bug labels Oct 16, 2025

Dunqing force-pushed the 10-16-fix_formatter_improve_handling_of_dangling_comments_in_if_statements branch from 9156a81 to 8c67314 Compare October 16, 2025 08:41

Dunqing force-pushed the 10-16-fix_formatter_don_t_print_callexpression_as_memberchain_style_when_its_only_has_one_argument_and_it_is_a_templateliteral_on_its_own_line branch from 4b98d98 to 6039089 Compare October 16, 2025 08:41

Dunqing marked this pull request as ready for review October 16, 2025 14:13

Dunqing mentioned this pull request Oct 16, 2025

fix(formatter): incorrect handling of ObjectPattern as a parameter #14670

Merged

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 16, 2025

fix(formatter): improve handling of dangling comments in if statements (

392bf74

#14658)

graphite-app bot force-pushed the 10-16-fix_formatter_don_t_print_callexpression_as_memberchain_style_when_its_only_has_one_argument_and_it_is_a_templateliteral_on_its_own_line branch from 6039089 to fd52b10 Compare October 16, 2025 21:52

graphite-app bot force-pushed the 10-16-fix_formatter_improve_handling_of_dangling_comments_in_if_statements branch from 8c67314 to 392bf74 Compare October 16, 2025 21:52

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 16, 2025

Base automatically changed from 10-16-fix_formatter_don_t_print_callexpression_as_memberchain_style_when_its_only_has_one_argument_and_it_is_a_templateliteral_on_its_own_line to main October 16, 2025 22:02

graphite-app bot merged commit 392bf74 into main Oct 16, 2025
21 checks passed

graphite-app bot deleted the 10-16-fix_formatter_improve_handling_of_dangling_comments_in_if_statements branch October 16, 2025 22:03

Boshen mentioned this pull request Oct 20, 2025

release(oxfmt): v0.6.0 #14804

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

fix(formatter): improve handling of dangling comments in if statements#14658

fix(formatter): improve handling of dangling comments in if statements#14658
graphite-app[bot] merged 1 commit intomainfrom
10-16-fix_formatter_improve_handling_of_dangling_comments_in_if_statements

Dunqing commented Oct 16, 2025

Uh oh!

Dunqing commented Oct 16, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Oct 16, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Comments

Conversation

Dunqing commented Oct 16, 2025

Uh oh!

Dunqing commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #14658 will degrade performances by 3.91%

Summary

Benchmarks breakdown

Footnotes

Uh oh!

graphite-app bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Dunqing commented Oct 16, 2025 •

edited

Loading

codspeed-hq bot commented Oct 16, 2025 •

edited

Loading

graphite-app bot commented Oct 16, 2025 •

edited

Loading