fix(formatter): skip the leading semicolon when calculating leading lines

[Dunqing]

No description provided.

[Dunqing]

• fix(formatter): incorrect handling of ObjectPattern as a parameter #14670
• fix(formatter): correct checking assignment layout for the right side with ownline comment and it is a PrivateFieldExpression #14664
• fix(formatter): should not merge tail with head for MemberChain when its parent is ArrowFunctionExpression #14663
• fix(formatter): should not indent BinaryLikeExpression when its parent is NewExpression #14662
• fix(formatter): should group nested test for TSConditionalType #14661
• fix(formatter): correct handling if a template literal should be printed as a signle line #14660
• fix(formatter): should group type parameters and parameters for method-like and function-like nodes #14659
• fix(formatter): improve handling of dangling comments in if statements #14658
• fix(formatter): don't print CallExpression as MemberChain style when its only has one argument and it is a TemplateLiteral on its own line #14657
• fix(formatter): don't group nested await expression when its is the leftmost expression #14656
• fix(formatter): correct checking function composition when the arguments have an call expression before function #14655
• fix(formatter): don't wrap parenthesis for type when its grandparent isn't a ExpressionStatement #14654
• fix(formatter): skip the leading semicolon when calculating leading lines #14653 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #14653 will not alter performance

_{Comparing 10-16-fix_formatter_skip_the_leading_semicolon_when_calculating_leading_lines (001b24e) with main (a9d50a7)¹}

Summary

✅ 33 untouched
⏩ 4 skipped²

Footnotes

1. No successful run was found on main (26c5f5a) during the generation of this report, so a9d50a7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull Request Overview

This PR fixes a formatting issue where the formatter incorrectly calculated leading lines when a semicolon preceded a statement, specifically affecting cases like ;(function() {})() where the leading semicolon should be considered when determining line breaks.

• Added logic to skip leading semicolons when calculating leading lines in the formatter
• Added test fixtures to verify the fix handles semicolon-prefixed expressions correctly

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_formatter/src/formatter/source_text.rs	Added logic to detect and skip leading semicolons when calculating leading lines
crates/oxc_formatter/tests/fixtures/js/semicolons/empty-line.js	Test input file with semicolon-prefixed IIFE to verify the fix
crates/oxc_formatter/tests/fixtures/js/semicolons/empty-line.js.snap	Expected test output showing correct formatting with and without semicolons
crates/oxc_formatter/tests/fixtures/js/semicolons/options.json	Test configuration for both semicolon true and false options

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[graphite-app]

Merge activity

• Oct 16, 9:49 PM UTC: leaysgur added this pull request to the Graphite merge queue.
• Oct 16, 9:58 PM UTC: Merged by the Graphite merge queue.