refactor(linter/language_server): `oxc_linter::Runtime::run_source` returns `Message` by Sysix · Pull Request #14428 · oxc-project/oxc

Sysix · 2025-10-07T22:26:17Z

Because oxc_linter::fixer::Message has now section_offset and thanks to #12647 in combination with #12724, the server has everything to calculate what it needs,
all relevant code can be moved to the language_server crate.

Next steps are to simplify the transformation to DiagnosticReport noticed by #14563

Sysix · 2025-10-07T22:26:33Z

refactor(linter/language_server): move all lsp relevant code to oxc_language_server crate #14430
refactor(linter/language_server): oxc_linter::TsgoLinter::run_source returns Message #14429
refactor(linter/language_server): oxc_linter::Runtime::run_source returns Message #14428 👈 (View in Graphite)
fix(language_server): use the first Span of the message as the primary Diagnostic range #14057
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-10-07T22:31:44Z

CodSpeed Performance Report

Merging #14428 will not alter performance

_{Comparing 10-08-refactor_linter_language_server_oxc_linter_runtime_run_source_returns_message_ (e5b7fb2) with main (493082c)¹}

Summary

✅ 4 untouched
⏩ 33 skipped²

No successful run was found on main (e5b7fb2) during the generation of this report, so 493082c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

camc314 · 2025-10-08T11:06:05Z

Merge activity

Oct 8, 11:06 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Oct 8, 11:06 AM UTC: camc314 added this pull request to the Graphite merge queue.
Oct 8, 11:10 AM UTC: Merged by the Graphite merge queue.

…eturns `Message` (#14428) Because `oxc_linter::fixer::Message` has now `section_offset` and thanks to #12647 in combination with #12724, the server has everything to calculate what it needs, all relevant code can be moved to the language_server crate. Next steps are to simplify the transformation to `DiagnosticReport` noticed by https://github.com/oxc-project/backlog/issues/175

## [1.21.0] - 2025-10-08 ### 🚀 Features - 576be20 linter/plugins: Support selectors DSL (#14435) (overlookmotel) - b2de44f linter/plugins: Support interpolation in normal diagnostic `message` (#14419) (overlookmotel) - 382c5be linter/plugins: Support placeholders in messageIds (#14416) (camc314) - 529e88e linter/plugins: Support `messageId`s (#14415) (camc314) - 83e7824 linter: Add `vue/require-default-export` rule (#14351) (Sysix) - ff98536 linter: Add `vue/no-import-compiler-macros` rule (#14335) (Sysix) - 0ec0847 ci: Run napi tests on windows (#14383) (camc314) ### 🐛 Bug Fixes - 11e0440 linter/jsx-handler-name: Improve handler name position in error messages (#14174) (Takuji Shimokawa) - 493082c language_server: Use the first Span of the message as the primary Diagnostic range (#14057) (Sysix) - 88ec1bd linter/plugins: Fix error messages (#14423) (overlookmotel) - 18616c2 oxlint: Ignore fixtures dir for vitest (#14414) (camc314) - ec02fe8 oxlint: Normalize path separators in snapshot tests (#14406) (camc314) - 6e8d2f6 language_server: Ignore JS plugins (#14379) (overlookmotel) - 96663fb linter/plugins: Do not call `before` hook if empty visitor (#14401) (overlookmotel) - 52f04bd linter: Use `pathToFileURL` for importing plugins to ensure correct URL format (#14394) (camc314) - 1ea0d46 oxlint: Resolve tsdown deprecation warning (#14389) (camc314) - bb679b5 linter: Promise/prefer-await-to-then strict option not reading from config (#14382) (camc314) ### 🚜 Refactor - 3374b8e linter/language_server: Move all lsp relevant code to `oxc_language_server` crate (#14430) (Sysix) - d24b74e linter/language_server: `oxc_linter::TsgoLinter::run_source` returns `Message` (#14429) (Sysix) - e5b7fb2 linter/language_server: `oxc_linter::Runtime::run_source` returns `Message` (#14428) (Sysix) - 3b26bf3 linter/plugins: Split adding visit function to compiler visitor into multiple functions (#14433) (overlookmotel) - af3a75e linter/plugins: Track ancestors while walking AST (#14432) (overlookmotel) - f279f0b linter/plugins: Do not lazy-load visitor keys (#14431) (overlookmotel) - 5e99ed3 linter/plugins: Allow nullish values as `message` or `messageId` (#14422) (overlookmotel) - dc30938 linter/plugins: Remove default value from `Context` constructor (#14421) (overlookmotel) - 28cfae0 oxlint: Use `vitest`s built in file snapshot comparison (#14392) (camc314) - 06b0e9f linter/plugins: Convert generated files to TS (#14385) (overlookmotel) - 52f35c6 napi/parser, linter/plugins: Rename `types.js` to `type_ids.js` (#14384) (overlookmotel) ### ⚡ Performance - 26435a1 linter/plugins: Small perf optimizations (#14420) (overlookmotel) - d8a8be1 linter/plugins: Avoid private methods (#14418) (overlookmotel) ### 🧪 Testing - d8da4a4 linter/plugins: Clarify tests for message placeholders (#14417) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

github-actions bot added A-linter Area - Linter A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 7, 2025

Sysix force-pushed the 10-08-refactor_linter_language_server_oxc_linter_runtime_run_source_returns_message_ branch from 4c39682 to 9e1f70e Compare October 7, 2025 22:42

This was referenced Oct 7, 2025

refactor(linter/language_server): oxc_linter::TsgoLinter::run_source returns Message #14429

Merged

refactor(linter/language_server): move all lsp relevant code to oxc_language_server crate #14430

Merged

Sysix changed the base branch from main to graphite-base/14428 October 7, 2025 23:47

Sysix force-pushed the 10-08-refactor_linter_language_server_oxc_linter_runtime_run_source_returns_message_ branch from 9e1f70e to 443dc60 Compare October 7, 2025 23:47

Sysix force-pushed the graphite-base/14428 branch from 88ec1bd to 553aa9a Compare October 7, 2025 23:47

Sysix changed the base branch from graphite-base/14428 to 09-23-fix_language_server_build_releated_spans_from_0_instead_of_max_lsp_int_ October 7, 2025 23:47

Sysix mentioned this pull request Oct 7, 2025

fix(language_server): use the first Span of the message as the primary Diagnostic range #14057

Merged

Sysix marked this pull request as ready for review October 7, 2025 23:54

Sysix requested a review from camc314 as a code owner October 7, 2025 23:54

Sysix mentioned this pull request Oct 8, 2025

fix(language_server): add whitespace for // oxlint-disable-next-line fix #14356

Merged

graphite-app bot changed the base branch from 09-23-fix_language_server_build_releated_spans_from_0_instead_of_max_lsp_int_ to graphite-base/14428 October 8, 2025 10:11

graphite-app bot force-pushed the 10-08-refactor_linter_language_server_oxc_linter_runtime_run_source_returns_message_ branch from 443dc60 to 7db2788 Compare October 8, 2025 10:16

graphite-app bot force-pushed the graphite-base/14428 branch from 553aa9a to 493082c Compare October 8, 2025 10:16

graphite-app bot changed the base branch from graphite-base/14428 to main October 8, 2025 10:17

graphite-app bot force-pushed the 10-08-refactor_linter_language_server_oxc_linter_runtime_run_source_returns_message_ branch from 7db2788 to 52c6c5e Compare October 8, 2025 10:17

camc314 added the 0-merge Merge with Graphite Merge Queue label Oct 8, 2025

graphite-app bot force-pushed the 10-08-refactor_linter_language_server_oxc_linter_runtime_run_source_returns_message_ branch from 52c6c5e to e5b7fb2 Compare October 8, 2025 11:06

graphite-app bot merged commit e5b7fb2 into main Oct 8, 2025
21 checks passed

graphite-app bot deleted the 10-08-refactor_linter_language_server_oxc_linter_runtime_run_source_returns_message_ branch October 8, 2025 11:10

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 8, 2025

Boshen mentioned this pull request Oct 8, 2025

release(oxlint): v1.21.0 #14441

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

refactor(linter/language_server): `oxc_linter::Runtime::run_source` returns `Message`#14428

refactor(linter/language_server): `oxc_linter::Runtime::run_source` returns `Message`#14428
graphite-app[bot] merged 1 commit intomainfrom
10-08-refactor_linter_language_server_oxc_linter_runtime_run_source_returns_message_

Sysix commented Oct 7, 2025 •

edited

Loading

Uh oh!

Sysix commented Oct 7, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Oct 7, 2025 •

edited

Loading

Uh oh!

camc314 commented Oct 8, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Comments

Conversation

Sysix commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #14428 will not alter performance

Summary

Footnotes

Uh oh!

camc314 commented Oct 8, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sysix commented Oct 7, 2025 •

edited

Loading

Sysix commented Oct 7, 2025 •

edited

Loading

codspeed-hq bot commented Oct 7, 2025 •

edited

Loading

camc314 commented Oct 8, 2025 •

edited by graphite-app bot

Loading