Skip to content

Comments

fix(linter): promise/prefer-await-to-then strict option not reading from config#14382

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/10-06-fix_linter_promise_prefer-await-to-then_strict_option_not_reading_from_config
Oct 6, 2025
Merged

fix(linter): promise/prefer-await-to-then strict option not reading from config#14382
graphite-app[bot] merged 1 commit intomainfrom
c/10-06-fix_linter_promise_prefer-await-to-then_strict_option_not_reading_from_config

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Oct 6, 2025 •
edited
Loading

fixes #14324

@camc314 camc314 marked this pull request as ready for review October 6, 2025 17:42
Copilot AI review requested due to automatic review settings October 6, 2025 17:42
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Oct 6, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot AI reviewed Oct 6, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the promise/prefer-await-to-then linter rule where the strict configuration option was not being properly read from the rule configuration. The fix updates the configuration parsing logic to correctly handle ESLint's array-based configuration format.

Key changes:

  • Updated configuration parsing to read from the first array element instead of directly from the object
  • Modified test cases to use the correct array-based configuration format
  • Added new test case to verify strict mode behavior

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/oxc_linter/src/rules/promise/prefer_await_to_then.rs Fixed configuration parsing and updated test cases to use proper ESLint config format
crates/oxc_linter/src/snapshots/promise_prefer_await_to_then.snap Added snapshot for new test case verifying strict mode behavior

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Oct 6, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 6, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the c/10-06-fix_linter_promise_prefer-await-to-then_strict_option_not_reading_from_config branch from ecc8f0a to bb679b5 Compare October 6, 2025 17:47
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 6, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #14382 will not alter performance

Comparing c/10-06-fix_linter_promise_prefer-await-to-then_strict_option_not_reading_from_config (bb679b5) with main (4bf6f69)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (bb679b5) during the generation of this report, so 4bf6f69 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@graphite-app graphite-app bot merged commit bb679b5 into main Oct 6, 2025
19 checks passed
@graphite-app graphite-app bot deleted the c/10-06-fix_linter_promise_prefer-await-to-then_strict_option_not_reading_from_config branch October 6, 2025 17:51
This was referenced Oct 8, 2025
Closed
Merged
camc314 added a commit that referenced this pull request Oct 8, 2025
@Boshen @camc314
release(oxlint): v1.21.0 (#14441)
6e061f6 
## [1.21.0] - 2025-10-08

### 🚀 Features

- 576be20 linter/plugins: Support selectors DSL (#14435) (overlookmotel)
- b2de44f linter/plugins: Support interpolation in normal diagnostic
`message` (#14419) (overlookmotel)
- 382c5be linter/plugins: Support placeholders in messageIds (#14416)
(camc314)
- 529e88e linter/plugins: Support `messageId`s (#14415) (camc314)
- 83e7824 linter: Add `vue/require-default-export` rule (#14351) (Sysix)
- ff98536 linter: Add `vue/no-import-compiler-macros` rule (#14335)
(Sysix)
- 0ec0847 ci: Run napi tests on windows (#14383) (camc314)

### 🐛 Bug Fixes

- 11e0440 linter/jsx-handler-name: Improve handler name position in
error messages (#14174) (Takuji Shimokawa)
- 493082c language_server: Use the first Span of the message as the
primary Diagnostic range (#14057) (Sysix)
- 88ec1bd linter/plugins: Fix error messages (#14423) (overlookmotel)
- 18616c2 oxlint: Ignore fixtures dir for vitest (#14414) (camc314)
- ec02fe8 oxlint: Normalize path separators in snapshot tests (#14406)
(camc314)
- 6e8d2f6 language_server: Ignore JS plugins (#14379) (overlookmotel)
- 96663fb linter/plugins: Do not call `before` hook if empty visitor
(#14401) (overlookmotel)
- 52f04bd linter: Use `pathToFileURL` for importing plugins to ensure
correct URL format (#14394) (camc314)
- 1ea0d46 oxlint: Resolve tsdown deprecation warning (#14389) (camc314)
- bb679b5 linter: Promise/prefer-await-to-then strict option not reading
from config (#14382) (camc314)

### 🚜 Refactor

- 3374b8e linter/language_server: Move all lsp relevant code to
`oxc_language_server` crate (#14430) (Sysix)
- d24b74e linter/language_server: `oxc_linter::TsgoLinter::run_source`
returns `Message` (#14429) (Sysix)
- e5b7fb2 linter/language_server: `oxc_linter::Runtime::run_source`
returns `Message` (#14428) (Sysix)
- 3b26bf3 linter/plugins: Split adding visit function to compiler
visitor into multiple functions (#14433) (overlookmotel)
- af3a75e linter/plugins: Track ancestors while walking AST (#14432)
(overlookmotel)
- f279f0b linter/plugins: Do not lazy-load visitor keys (#14431)
(overlookmotel)
- 5e99ed3 linter/plugins: Allow nullish values as `message` or
`messageId` (#14422) (overlookmotel)
- dc30938 linter/plugins: Remove default value from `Context`
constructor (#14421) (overlookmotel)
- 28cfae0 oxlint: Use `vitest`s built in file snapshot comparison
(#14392) (camc314)
- 06b0e9f linter/plugins: Convert generated files to TS (#14385)
(overlookmotel)
- 52f35c6 napi/parser, linter/plugins: Rename `types.js` to
`type_ids.js` (#14384) (overlookmotel)

### ⚡ Performance

- 26435a1 linter/plugins: Small perf optimizations (#14420)
(overlookmotel)
- d8a8be1 linter/plugins: Avoid private methods (#14418) (overlookmotel)

### 🧪 Testing

- d8da4a4 linter/plugins: Clarify tests for message placeholders
(#14417) (overlookmotel)

Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

linter: promise/prefer-await-to-then 'strict' is not working with example

1 participant

@camc314