Skip to content

perf(parser): cache has_separator() result in literal parsing #14403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 1 commit into from
Oct 7, 2025
Merged

perf(parser): cache has_separator() result in literal parsing #14403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions crates/oxc_parser/src/js/expression.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,12 +305,13 @@ impl<'a> ParserImpl<'a> {
let span = token.span();
let kind = token.kind();
let src = self.cur_src();
let has_separator = token.has_separator();
let value = match kind {
Kind::Decimal | Kind::Binary | Kind::Octal | Kind::Hex => {
parse_int(src, kind, token.has_separator())
parse_int(src, kind, has_separator)
}
Kind::Float | Kind::PositiveExponential | Kind::NegativeExponential => {
parse_float(src, token.has_separator())
parse_float(src, has_separator)
}
_ => unreachable!(),
};
Expand Down Expand Up @@ -340,6 +341,7 @@ impl<'a> ParserImpl<'a> {
pub(crate) fn parse_literal_bigint(&mut self) -> BigIntLiteral<'a> {
let token = self.cur_token();
let kind = token.kind();
let has_separator = token.has_separator();
let base = match kind {
Kind::Decimal => BigintBase::Decimal,
Kind::Binary => BigintBase::Binary,
Expand All @@ -350,7 +352,7 @@ impl<'a> ParserImpl<'a> {
let span = token.span();
let raw = self.cur_src();
let src = raw.strip_suffix('n').unwrap();
let value = parse_big_int(src, kind, token.has_separator(), self.ast.allocator);
let value = parse_big_int(src, kind, has_separator, self.ast.allocator);

self.bump_any();
self.ast.big_int_literal(span, value, Some(Atom::from(raw)), base)
Expand Down
Loading