perf(parser): cache has_separator() result in literal parsing#14403
Merged
perf(parser): cache has_separator() result in literal parsing#14403
has_separator() result in literal parsing#14403Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Optimize numeric literal parsing by caching the has_separator() result to eliminate redundant memory reads and pointer arithmetic operations.
- Cache
token.has_separator()result in local variable instead of calling it multiple times - Apply optimization to both
parse_literal_number()andparse_literal_bigint()functions - Reduce memory access overhead on the hot path for parsing millions of numeric literals
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Member
Author
Merge activity
|
CodSpeed Performance ReportMerging #14403 will not alter performanceComparing Summary
|
## Summary Cache the `token.has_separator()` result in `parse_literal_number()` and `parse_literal_bigint()` to avoid redundant memory reads on the hot path.
537076e to
29fa3a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cache the
token.has_separator()result inparse_literal_number()andparse_literal_bigint()to avoid redundant memory reads on the hot path.