feat(formatter): normalize key of TSPropertySignature#14083
Merged
graphite-app[bot] merged 1 commit intomainfrom Sep 29, 2025
Merged
Conversation
Member
Author
CodSpeed Instrumentation Performance ReportMerging #14083 will not alter performanceComparing Summary
Footnotes
|
726e28f to
47e0819
Compare
33f6166 to
495dddf
Compare
This was referenced Sep 25, 2025
495dddf to
9dc5d63
Compare
47e0819 to
453f528
Compare
Contributor
Merge activity
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes formatter handling of TypeScript property signature keys by normalizing them through the proper formatting function. The change improves compatibility with Prettier's output format.
- Replaces direct key writing with
format_property_keyfor non-computed TypeScript property signatures - Increases Prettier compatibility from 528/573 (92.15%) to 529/573 (92.32%)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/oxc_formatter/src/write/mod.rs | Updates TSPropertySignature formatting to use format_property_key for non-computed keys |
| tasks/prettier_conformance/snapshots/prettier.ts.snap.md | Reflects improved test compatibility score and removal of previously failing test case |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
7c21667 to
90fd46f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.