refactor(napi): move scripts into scripts directory#14048
Merged
graphite-app[bot] merged 1 commit intomainfrom Sep 23, 2025
Merged
refactor(napi): move scripts into scripts directory#14048graphite-app[bot] merged 1 commit intomainfrom
scripts directory#14048graphite-app[bot] merged 1 commit intomainfrom
Conversation
github-actions
bot
added
A-parser
This was referenced Sep 23, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
camc314
approved these changes
Sep 23, 2025
Contributor
Merge activity
|
overlookmotel
force-pushed
the
09-23-refactor_napi_move_scripts_into_scripts_directory
branch
from
7eac237 to
df51f57
Compare
overlookmotel
force-pushed
the
09-23-fix_napi_minifier_napi_transformer_rename_commonjs_file_to_.cjs_
branch
from
501c137 to
da59eaa
Compare
Move all build scripts in `napi` packages into a `scripts` dir. These packages don't have root directories with tons of files like `napi/parser` and `apps/oxlint` do, but IMO it's preferable to have a consistent directory structure in all NAPI packages. Also, rename these scripts from `.mjs` to `.js`, since these packages are ESM.
graphite-app
bot
force-pushed
the
09-23-fix_napi_minifier_napi_transformer_rename_commonjs_file_to_.cjs_
branch
from
da59eaa to
2f9e16d
Compare
graphite-app
bot
force-pushed
the
09-23-refactor_napi_move_scripts_into_scripts_directory
branch
from
df51f57 to
cc0019f
Compare
Base automatically changed from
09-23-fix_napi_minifier_napi_transformer_rename_commonjs_file_to_.cjs_
to
main
September 23, 2025 14:54
graphite-app
bot
deleted the
09-23-refactor_napi_move_scripts_into_scripts_directory
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move all build scripts in
napipackages into ascriptsdir. These packages don't have root directories with tons of files likenapi/parserandapps/oxlintdo, but IMO it's preferable to have a consistent directory structure in all NAPI packages.Also, rename these scripts from
.mjsto.js, since these packages are ESM.