Skip to content

Comments

fix(napi/minifier, napi/transformer): rename CommonJS file to .cjs#14047

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-23-fix_napi_minifier_napi_transformer_rename_commonjs_file_to_.cjs_
Sep 23, 2025
Merged

fix(napi/minifier, napi/transformer): rename CommonJS file to .cjs#14047
graphite-app[bot] merged 1 commit intomainfrom
09-23-fix_napi_minifier_napi_transformer_rename_commonjs_file_to_.cjs_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 23, 2025

webcontainer-fallback.js in napi/minify and napi/transform are CommonJS files, but these packages are ESM. Rename them to webcontainer-fallback.cjs to avoid module resolution errors/fallbacks.

@github-actions github-actions bot added A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler C-bug Category - Bug labels Sep 23, 2025
Copy link
Member Author

overlookmotel commented Sep 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Sep 23, 2025
Copy link
Contributor

camc314 commented Sep 23, 2025

Merge activity

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 23, 2025
@overlookmotel overlookmotel force-pushed the 09-23-fix_napi_minifier_napi_transformer_rename_commonjs_file_to_.cjs_ branch from 501c137 to da59eaa Compare September 23, 2025 14:41
@overlookmotel overlookmotel force-pushed the 09-23-refactor_oxfmt_rename_build_script_to_.js_ branch from 184c7d3 to 396e3a3 Compare September 23, 2025 14:41
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 23, 2025
…14047)

`webcontainer-fallback.js` in `napi/minify` and `napi/transform` are CommonJS files, but these packages are ESM. Rename them to `webcontainer-fallback.cjs` to avoid module resolution errors/fallbacks.
@graphite-app graphite-app bot force-pushed the 09-23-refactor_oxfmt_rename_build_script_to_.js_ branch from 396e3a3 to 226deee Compare September 23, 2025 14:48
@graphite-app graphite-app bot force-pushed the 09-23-fix_napi_minifier_napi_transformer_rename_commonjs_file_to_.cjs_ branch from da59eaa to 2f9e16d Compare September 23, 2025 14:48
Base automatically changed from 09-23-refactor_oxfmt_rename_build_script_to_.js_ to main September 23, 2025 14:54
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 23, 2025
@graphite-app graphite-app bot merged commit 2f9e16d into main Sep 23, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 09-23-fix_napi_minifier_napi_transformer_rename_commonjs_file_to_.cjs_ branch September 23, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants