Skip to content

chore(deps): update oxc-miette to v2.5.0 #13829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Sysix wants to merge 1 commit into from
Closed

chore(deps): update oxc-miette to v2.5.0 #13829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ lazy-regex = "3.4.1"
log = "0.4.27"
markdown = "1.0.0"
memchr = "2.7.5"
miette = { package = "oxc-miette", version = "2.4.0", features = ["fancy-no-syscall"] }
miette = { package = "oxc-miette", version = "2.5.0", features = ["fancy-no-syscall"] }
mimalloc-safe = "0.1.54"
nonmax = "0.5.5"
num-bigint = "0.4.6"
Expand Down
20 changes: 10 additions & 10 deletions crates/oxc_linter/src/snapshots/eslint_no_irregular_whitespace.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ source: crates/oxc_linter/src/tester.rs
╭─[no_irregular_whitespace.tsx:2:14]
1 │ var any 　 = 'thing', other 　 = 'thing';
2 │ var third 　 = 'thing';
· ──
· ─
╰────
help: Try to remove the irregular whitespace

Expand Down Expand Up @@ -237,23 +237,23 @@ source: crates/oxc_linter/src/tester.rs
╭─[no_irregular_whitespace.tsx:2:13]
1 │ `　multiline
2 │ template`　
· ──
· ─
╰────
help: Try to remove the irregular whitespace

⚠ eslint(no-irregular-whitespace): Unexpected irregular whitespace
╭─[no_irregular_whitespace.tsx:2:4]
1 │ `　template`
2 │ 　
· ──
· ─
╰────
help: Try to remove the irregular whitespace

⚠ eslint(no-irregular-whitespace): Unexpected irregular whitespace
╭─[no_irregular_whitespace.tsx:3:4]
2 │ template`
3 │ 　
· ──
· ─
╰────
help: Try to remove the irregular whitespace

Expand Down Expand Up @@ -281,7 +281,7 @@ source: crates/oxc_linter/src/tester.rs
⚠ eslint(no-irregular-whitespace): Unexpected irregular whitespace
╭─[no_irregular_whitespace.tsx:1:12]
1 │ var foo = bar;
· ─
· ─
╰────
help: Try to remove the irregular whitespace

Expand All @@ -295,7 +295,7 @@ source: crates/oxc_linter/src/tester.rs
⚠ eslint(no-irregular-whitespace): Unexpected irregular whitespace
╭─[no_irregular_whitespace.tsx:1:12]
1 │ var foo = bar;
· ─
· ─
╰────
help: Try to remove the irregular whitespace

Expand All @@ -309,7 +309,7 @@ source: crates/oxc_linter/src/tester.rs
⚠ eslint(no-irregular-whitespace): Unexpected irregular whitespace
╭─[no_irregular_whitespace.tsx:1:13]
1 │ var foo = bar;
· ─
· ─
╰────
help: Try to remove the irregular whitespace

Expand All @@ -323,7 +323,7 @@ source: crates/oxc_linter/src/tester.rs
⚠ eslint(no-irregular-whitespace): Unexpected irregular whitespace
╭─[no_irregular_whitespace.tsx:1:15]
1 │ var foo = bar ;
· ─
· ─
╰────
help: Try to remove the irregular whitespace

Expand Down Expand Up @@ -376,7 +376,7 @@ source: crates/oxc_linter/src/tester.rs
╭─[no_irregular_whitespace.tsx:2:10]
1 │ var foo =
2 │ bar
· ─
· ─
3 │ ;
╰────
help: Try to remove the irregular whitespace
Expand All @@ -385,7 +385,7 @@ source: crates/oxc_linter/src/tester.rs
╭─[no_irregular_whitespace.tsx:2:11]
1 │ var foo =
2 │ bar
· ─
· ─
3 │ ;
╰────
help: Try to remove the irregular whitespace
Expand Down
4 changes: 2 additions & 2 deletions crates/oxc_linter/src/snapshots/eslint_no_useless_escape.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,14 +437,14 @@ source: crates/oxc_linter/src/tester.rs
⚠ eslint(no-useless-escape): Unnecessary escape character '\u{85}'
╭─[no_useless_escape.tsx:1:40]
1 │ var stringLiteralWithNextLine = "line 1\…line 2";
· ─
· ──
╰────
help: Replace `\…` with `…`.

⚠ eslint(no-useless-escape): Unnecessary escape character '\u{85}'
╭─[no_useless_escape.tsx:1:40]
1 │ var stringLiteralWithNextLine = `line 1\…line 2`;
· ─
· ──
╰────
help: Replace `\…` with `…`.

Expand Down
4 changes: 2 additions & 2 deletions crates/oxc_linter/src/snapshots/eslint_prefer_numeric_literals.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ source: crates/oxc_linter/src/tester.rs
⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1]
1 │ parseInt('1️⃣3️⃣3️⃣7️⃣', 16);
· ────────────────────
· ────────────────────────
╰────

⚠ eslint(prefer-numeric-literals): Use octal literals instead of parseInt().
Expand All @@ -88,7 +88,7 @@ source: crates/oxc_linter/src/tester.rs
⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1]
1 │ Number.parseInt('1️⃣3️⃣3️⃣7️⃣', 16);
· ───────────────────────────
· ───────────────────────────────
Copy link
Contributor

@camc314 camc314 Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:sigh: i thought i fixed this, but some of these are still off by one 🫠

Copy link
Member Author

@Sysix Sysix Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in no-misleading-character-class there is some offs too, but some are not:


  ⚠ eslint(no-misleading-character-class): Unexpected joined character sequence in character class.
   ╭─[no_misleading_character_class.tsx:1:21]
 1 │ var r = new RegExp("[👨‍👩‍👦]", "u")
   ·                     ────
   ╰────

  ⚠ eslint(no-misleading-character-class): Unexpected joined character sequence in character class.
   ╭─[no_misleading_character_class.tsx:1:21]
 1 │ var r = new RegExp("[👩‍👦]", "u")
   ·                     ────
   ╰────

Copy link
Contributor

@camc314 camc314 Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both of those look correct? or are they not?

Copy link
Member Author

@Sysix Sysix Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first one does not include the ]

Copy link
Contributor

@camc314 camc314 Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah github just isn't showing it to me

╰────

⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt().
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_linter/src/snapshots/eslint_prefer_object_has_own.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,6 @@ source: crates/oxc_linter/src/tester.rs
⚠ eslint(prefer-object-has-own): Disallow use of `Object.prototype.hasOwnProperty.call()` and prefer use of `Object.hasOwn()`.
╭─[prefer_object_has_own.tsx:1:3]
1 │ …Object.prototype.hasOwnProperty.call(C,x);
· ─────────────────────────────────────────
· ─────────────────────────────────────────
╰────
help: Replace `Object.prototype.hasOwnProperty.call` with ` Object.hasOwn`.
4 changes: 2 additions & 2 deletions crates/oxc_linter/src/snapshots/eslint_prefer_template.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ source: crates/oxc_linter/src/tester.rs
⚠ eslint(prefer-template): Unexpected string concatenation.
╭─[prefer_template.tsx:1:1]
1 │ foo + '8'
· ─────────
· ──────────
╰────
help: Use template literals instead of string concatenation.

Expand All @@ -228,7 +228,7 @@ source: crates/oxc_linter/src/tester.rs
⚠ eslint(prefer-template): Unexpected string concatenation.
╭─[prefer_template.tsx:1:1]
1 │ foo + ''
· ────────
· ─────────
╰────
help: Use template literals instead of string concatenation.

Expand Down
4 changes: 2 additions & 2 deletions crates/oxc_linter/src/snapshots/react_jsx_curly_brace_presence.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,8 @@ source: crates/oxc_linter/src/tester.rs
⚠ eslint-plugin-react(jsx-curly-brace-presence): Curly braces are required here.
╭─[jsx_curly_brace_presence.tsx:1:14]
1 │ <MyComponent>foo bar </MyComponent>
· ────┬────
· ╰── Wrap this value in curly braces
· ─────┬────
· ╰── Wrap this value in curly braces
╰────
help: Wrap this value in curly braces

Expand Down
8 changes: 4 additions & 4 deletions crates/oxc_linter/src/snapshots/typescript_consistent_type_definitions.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,27 +150,27 @@ source: crates/oxc_linter/src/tester.rs
⚠ typescript-eslint(consistent-type-definitions): Use an `interface` instead of a `type`
╭─[consistent_type_definitions.tsx:1:10]
1 │ declare…type S={}
· ────
· ────
╰────
help: Use an `interface` instead of a `type`

⚠ typescript-eslint(consistent-type-definitions): Use an `type` instead of a `interface`
╭─[consistent_type_definitions.tsx:1:10]
1 │ declare…interface S {}
· ─────────
· ─────────
╰────
help: Use an `type` instead of a `interface`

⚠ typescript-eslint(consistent-type-definitions): Use an `interface` instead of a `type`
╭─[consistent_type_definitions.tsx:1:17]
1 │ export declare…type S={}
· ────
· ────
╰────
help: Use an `interface` instead of a `type`

⚠ typescript-eslint(consistent-type-definitions): Use an `type` instead of a `interface`
╭─[consistent_type_definitions.tsx:1:17]
1 │ export declare…interface S {}
· ─────────
· ─────────
╰────
help: Use an `type` instead of a `interface`
12 changes: 6 additions & 6 deletions tasks/coverage/snapshots/parser_babel.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2169,7 +2169,7 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
× Unexpected token
╭─[babel/packages/babel-parser/test/fixtures/core/uncategorised/436/input.js:2:1]
1 │ ]
· ─
· ─
╰────

× Unexpected token
Expand All @@ -2182,7 +2182,7 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
× Unexpected token
╭─[babel/packages/babel-parser/test/fixtures/core/uncategorised/438/input.js:3:1]
2 │ ]
· ─
· ─
╰────

× Unexpected token
Expand All @@ -2195,7 +2195,7 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
× Unexpected token
╭─[babel/packages/babel-parser/test/fixtures/core/uncategorised/440/input.js:3:1]
2 │ ]
· ─
· ─
╰────

× Unterminated regular expression
Expand Down Expand Up @@ -2228,7 +2228,7 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
× Unexpected token
╭─[babel/packages/babel-parser/test/fixtures/core/uncategorised/444/input.js:3:3]
2 │ */]
· ─
· ─
╰────

× Unexpected token
Expand Down Expand Up @@ -11174,7 +11174,7 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
× Unexpected token
╭─[babel/packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0156/input.js:3:1]
2 │ ]
· ─
· ─
╰────

× Unterminated regular expression
Expand Down Expand Up @@ -11207,7 +11207,7 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
× Unexpected token
╭─[babel/packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0160/input.js:3:3]
2 │ */]
· ─
· ─
╰────

× Unexpected token
Expand Down
8 changes: 4 additions & 4 deletions tasks/coverage/snapshots/parser_test262.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21411,7 +21411,7 @@ Expect to Parse: tasks/coverage/test262/test/annexB/language/expressions/assignm
× Expected a semicolon or an implicit semicolon after a statement, but found none
╭─[test262/test/language/line-terminators/invalid-comment-single-cr.js:18:6]
17 │ // this text is not included in the single-line comment that precedes it
· ▲
· ▲
╰────
help: Try insert a semicolon here

Expand Down Expand Up @@ -21441,14 +21441,14 @@ Expect to Parse: tasks/coverage/test262/test/annexB/language/expressions/assignm
╭─[test262/test/language/line-terminators/invalid-regexp-cr.js:18:1]
17 │
18 │ //
· ─
· ──
╰────

× Unexpected token
╭─[test262/test/language/line-terminators/invalid-regexp-cr.js:18:1]
17 │
18 │ //
· ───
· ────
╰────

× Unterminated regular expression
Expand Down Expand Up @@ -21498,7 +21498,7 @@ Expect to Parse: tasks/coverage/test262/test/annexB/language/expressions/assignm
╭─[test262/test/language/line-terminators/invalid-string-cr.js:17:1]
16 │
17 │ ''
· ─
· ──
╰────

× Unterminated string
Expand Down
6 changes: 3 additions & 3 deletions tasks/coverage/snapshots/parser_typescript.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11818,23 +11818,23 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
╭─[typescript/tests/cases/compiler/regularExpressionCharacterClassRangeOrder.ts:7:8]
6 │ const regexes: RegExp[] = [
7 │ /[𝘈-𝘡][𝘡-𝘈]/,
· ──
· ─
8 │ /[𝘈-𝘡][𝘡-𝘈]/u,
╰────

× Invalid regular expression: Character class atom range out of order
╭─[typescript/tests/cases/compiler/regularExpressionCharacterClassRangeOrder.ts:8:19]
7 │ /[𝘈-𝘡][𝘡-𝘈]/,
8 │ /[𝘈-𝘡][𝘡-𝘈]/u,
· ──
· ─
9 │ /[𝘈-𝘡][𝘡-𝘈]/v,
╰────

× Invalid regular expression: Character class set range out of order
╭─[typescript/tests/cases/compiler/regularExpressionCharacterClassRangeOrder.ts:9:15]
8 │ /[𝘈-𝘡][𝘡-𝘈]/u,
9 │ /[𝘈-𝘡][𝘡-𝘈]/v,
· ───
· ─
10 │
╰────

Expand Down
Loading