Skip to content

Comments

chore(deps): update oxc-miette to v2.5.0#13829

Closed
Sysix wants to merge 1 commit intomainfrom
09-16-chore_deps_update_oxc-miette_to_v2.5.0
Closed

chore(deps): update oxc-miette to v2.5.0#13829
Sysix wants to merge 1 commit intomainfrom
09-16-chore_deps_update_oxc-miette_to_v2.5.0

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Sep 16, 2025

No description provided.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Sep 16, 2025
Copy link
Member Author

Sysix commented Sep 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix marked this pull request as ready for review September 16, 2025 16:52
@Sysix Sysix requested a review from camc314 as a code owner September 16, 2025 16:52
Copilot AI review requested due to automatic review settings September 16, 2025 16:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the oxc-miette dependency from version 2.4.0 to 2.5.0. The update includes changes to error message display formatting in the miette diagnostic library.

  • Updated oxc-miette package version in Cargo.toml
  • Updated snapshot tests to reflect formatting changes in error display
  • Adjusted underline positioning in diagnostic output

Reviewed Changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Cargo.toml Updated oxc-miette version from 2.4.0 to 2.5.0
crates/oxc_linter/src/snapshots/react_jsx_curly_brace_presence.snap Updated underline positioning in diagnostic output
crates/oxc_linter/src/snapshots/eslint_prefer_template.snap Updated underline length in diagnostic display
crates/oxc_linter/src/snapshots/eslint_prefer_numeric_literals.snap Updated underline length for emoji-containing code
crates/oxc_linter/src/snapshots/eslint_no_useless_escape.snap Updated underline width for escape character highlighting
crates/oxc_linter/src/snapshots/eslint_no_irregular_whitespace.snap Updated underline width for whitespace character highlighting

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 16, 2025

CodSpeed Instrumentation Performance Report

Merging #13829 will not alter performance

Comparing 09-16-chore_deps_update_oxc-miette_to_v2.5.0 (b116b2c) with main (395d40d)

Summary

✅ 37 untouched

@Sysix Sysix force-pushed the 09-16-chore_deps_update_oxc-miette_to_v2.5.0 branch from c9eba6d to b116b2c Compare September 16, 2025 16:59
╭─[prefer_numeric_literals.tsx:1:1]
1 │ Number.parseInt('1️⃣3️⃣3️⃣7️⃣', 16);
· ───────────────────────────
· ───────────────────────────────
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:sigh: i thought i fixed this, but some of these are still off by one 🫠

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in no-misleading-character-class there is some offs too, but some are not:


  ⚠ eslint(no-misleading-character-class): Unexpected joined character sequence in character class.
   ╭─[no_misleading_character_class.tsx:1:21]
 1 │ var r = new RegExp("[👨‍👩‍👦]", "u")
   ·                     ────
   ╰────

  ⚠ eslint(no-misleading-character-class): Unexpected joined character sequence in character class.
   ╭─[no_misleading_character_class.tsx:1:21]
 1 │ var r = new RegExp("[👩‍👦]", "u")
   ·                     ────
   ╰────

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both of those look correct? or are they not?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first one does not include the ]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah github just isn't showing it to me

@Boshen
Copy link
Member

Boshen commented Sep 18, 2025

Updated in #13880

@Boshen Boshen closed this Sep 18, 2025
@Sysix Sysix deleted the 09-16-chore_deps_update_oxc-miette_to_v2.5.0 branch October 3, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants