Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the oxc-miette dependency from version 2.4.0 to 2.5.0. The update includes changes to error message display formatting in the miette diagnostic library.
- Updated
oxc-miettepackage version in Cargo.toml - Updated snapshot tests to reflect formatting changes in error display
- Adjusted underline positioning in diagnostic output
Reviewed Changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Updated oxc-miette version from 2.4.0 to 2.5.0 |
| crates/oxc_linter/src/snapshots/react_jsx_curly_brace_presence.snap | Updated underline positioning in diagnostic output |
| crates/oxc_linter/src/snapshots/eslint_prefer_template.snap | Updated underline length in diagnostic display |
| crates/oxc_linter/src/snapshots/eslint_prefer_numeric_literals.snap | Updated underline length for emoji-containing code |
| crates/oxc_linter/src/snapshots/eslint_no_useless_escape.snap | Updated underline width for escape character highlighting |
| crates/oxc_linter/src/snapshots/eslint_no_irregular_whitespace.snap | Updated underline width for whitespace character highlighting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CodSpeed Instrumentation Performance ReportMerging #13829 will not alter performanceComparing Summary
|
c9eba6d to
b116b2c
Compare
| ╭─[prefer_numeric_literals.tsx:1:1] | ||
| 1 │ Number.parseInt('1️⃣3️⃣3️⃣7️⃣', 16); | ||
| · ─────────────────────────── | ||
| · ─────────────────────────────── |
There was a problem hiding this comment.
:sigh: i thought i fixed this, but some of these are still off by one 🫠
There was a problem hiding this comment.
in no-misleading-character-class there is some offs too, but some are not:
⚠ eslint(no-misleading-character-class): Unexpected joined character sequence in character class.
╭─[no_misleading_character_class.tsx:1:21]
1 │ var r = new RegExp("[👨👩👦]", "u")
· ────
╰────
⚠ eslint(no-misleading-character-class): Unexpected joined character sequence in character class.
╭─[no_misleading_character_class.tsx:1:21]
1 │ var r = new RegExp("[👩👦]", "u")
· ────
╰────
There was a problem hiding this comment.
both of those look correct? or are they not?
There was a problem hiding this comment.
The first one does not include the ]
There was a problem hiding this comment.
ah github just isn't showing it to me
|
Updated in #13880 |

No description provided.