test(linter/no-unused-vars): add test for non ASCII chars in JSX components by camc314 · Pull Request #13820 · oxc-project/oxc

camc314 · 2025-09-16T09:30:50Z

adds a test based on the above PR in the stack

camc314 · 2025-09-16T09:31:05Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-09-16T09:36:48Z

CodSpeed Instrumentation Performance Report

Merging #13820 will not alter performance

_{Comparing c/09-16-test_linter_no-unused-vars_add_test_for_non_ascii_chars_in_jsx_components (cb080de) with main (00e4477)¹}

Summary

✅ 37 untouched

No successful run was found on main (cb080de) during the generation of this report, so 00e4477 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Boshen · 2025-09-16T10:11:27Z

Merge activity

Sep 16, 10:11 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 16, 10:11 AM UTC: Boshen added this pull request to the Graphite merge queue.
Sep 16, 10:23 AM UTC: Merged by the Graphite merge queue.

…onents (#13820) adds a test based on the above PR in the stack

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

## [1.16.0] - 2025-09-16 ### 🚀 Features - 97c8d06 linter: Add `preserve-caught-error` rule (#13748) (孔辉) - 8c19b18 linter/exhaustive-deps: Implement fixer for dep in global scope (#13783) (camc314) - 06bce8f linter/exhaustive-deps: Implement fixer for missing dep (#13782) (camc314) - a8675f4 linter: Add eslint/class-methods-use-this rule (#12977) (Peter Cardenas) - db33196 parser: Adds typescript rule for empty argument list (#13730) (Karan Kiri) - 2751193 linter: Add `eslint/no-useless-computed-key` rule (#13428) (yefan) - 9a205d1 regex-parser: Parse simple `TemplateLiterals` (#13265) (Sysix) ### 🐛 Bug Fixes - a2c91cd linter: Drop `rules` to allow mutable access to `ctx_host` in `run_external_rules` (#13832) (camc314) - 3af1e5d linter/no-unsafe-declaration-merging: Always mark first span as primary (#13830) (camc314) - 1c43c7c linter: Keep message when merging composite fixes (#13827) (camc314) - 26af302 linter/exhaustive-deps: Check stable value is on lhs of assignment expr (#13815) (camc314) - 4bc12d0 linter/exhaustive-deps: Remove impossible comparison with parent kind (#13814) (camc314) - 12baf5e linter/exhaustive-deps: Respect primary span when identifying disable directive location (#13781) (camc314) - fa7400a linter/no-undef: False positive with `arguments` in functions (#13763) (camc314) - 50e6e3c editor: Restrict servers paths for `oxc.path.server` (#13740) (Sysix) - b45077d editor: Strip leading slash for bin path on windows (#13738) (Sysix) - 8fa6227 editor: Don't allow `oxc.path.server` for untrusted workspaces (#13734) (Sysix) - 56da114 linter/react/jsx-handler-names: Do not detect the function name within the inline-function's body block (#13456) (Takuji Shimokawa) - b2bc5b4 linter/react-perf/jsx-no-new-object-as-prop: Skip as/satisfies exprs (#13718) (camc314) - ab51394 raw_transfer: Disable layout assertions on some 32-bit platforms (#13716) (overlookmotel) - 09428f6 linter/plugins: Remove outdated comment (#13691) (overlookmotel) - a294721 linter/plugins: Exit early if JS plugins enabled on unsupported platforms (#13689) (overlookmotel) - 68a2280 linter/plugins: More graceful exit for `--experimental-js-plugins` CLI option (#13688) (overlookmotel) ### 🚜 Refactor - 395d40d linter: Derive inmpls for `PartialEq`, `Eq` over manual ones (#13828) (camc314) - 8e4cd8f linter/func-names: Use `run_once` over looping over all nodes (#13798) (camc314) - 7f4e2fe eslint/func-names: Clean up implementation and improve documentation (#13601) (Antoine Zanardi) - 137896a language_server: Split options for linting and formatting (#13627) (Sysix) - 7346099 linter: Move `oxlint` application code into separate module (#13745) (overlookmotel) - 6dd4107 linter: Remove `#[cfg(test)]` attributes from `tester` module (#13714) (overlookmotel) - c40c6ef linter/plugins: Directory for JS plugins-related code (#13701) (overlookmotel) - a0022c1 linter/plugins: Improve error messages for JS plugins (#13699) (overlookmotel) - 1fd993f napi/oxlint: Rename `napi/oxlint2` to `napi/oxlint` (#13682) (overlookmotel) ### ⚡ Performance - 90c8286 linter: Detect node types from `let..else` statements (#13690) (camchenry) - 08c05df semantic: Make CFG construction a compile-time feature (#13678) (Boshen) ### 🎨 Styling - 99a7638 linter: Add comments + re-organise imports (#13715) (overlookmotel) ### 🧪 Testing - 18a1145 linter: Add debug assertions for skipping rules (#13724) (camc314) - cb080de linter/no-unused-vars: Add test for non ASCII chars in JSX components (#13820) (camc314) - b6eba27 linter/no-undef: Add more test cases for `arguments` (#13764) (camc314) - fb2d087 linter: Set CWD for tests (#13722) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

github-actions bot added A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Sep 16, 2025

camc314 mentioned this pull request Sep 16, 2025

fix(parser): update ident reference check in jsx #13819

Merged

camc314 assigned Boshen Sep 16, 2025

camc314 requested a review from Boshen September 16, 2025 09:32

camc314 marked this pull request as ready for review September 16, 2025 09:32

camc314 force-pushed the c/09-16-test_linter_no-unused-vars_add_test_for_non_ascii_chars_in_jsx_components branch from 6339f64 to 0afc166 Compare September 16, 2025 09:36

camc314 force-pushed the c/09-16-test_linter_no-unused-vars_add_test_for_non_ascii_chars_in_jsx_components branch from 0afc166 to 92f7a9c Compare September 16, 2025 09:41

Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 16, 2025

graphite-app bot force-pushed the c/09-16-fix_parser_update_ident_reference_check_in_jsx branch from 4e5f887 to 00e4477 Compare September 16, 2025 10:11

graphite-app bot pushed a commit that referenced this pull request Sep 16, 2025

test(linter/no-unused-vars): add test for non ASCII chars in JSX comp…

09282ce

…onents (#13820) adds a test based on the above PR in the stack

graphite-app bot force-pushed the c/09-16-test_linter_no-unused-vars_add_test_for_non_ascii_chars_in_jsx_components branch from 92f7a9c to 09282ce Compare September 16, 2025 10:12

Base automatically changed from c/09-16-fix_parser_update_ident_reference_check_in_jsx to main September 16, 2025 10:17

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 16, 2025

test(linter/no-unused-vars): add test for non ASCII chars in JSX comp…

cb080de

…onents (#13820) adds a test based on the above PR in the stack

Copilot AI review requested due to automatic review settings September 16, 2025 10:18

graphite-app bot force-pushed the c/09-16-test_linter_no-unused-vars_add_test_for_non_ascii_chars_in_jsx_components branch from 09282ce to cb080de Compare September 16, 2025 10:18

Copilot AI reviewed Sep 16, 2025

View reviewed changes

graphite-app bot merged commit cb080de into main Sep 16, 2025
48 checks passed

graphite-app bot deleted the c/09-16-test_linter_no-unused-vars_add_test_for_non_ascii_chars_in_jsx_components branch September 16, 2025 10:23

This was referenced Sep 16, 2025

release(oxlint): v1.16.0 #13831

Closed

release(oxlint): v1.16.0 #13833

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

test(linter/no-unused-vars): add test for non ASCII chars in JSX components#13820

test(linter/no-unused-vars): add test for non ASCII chars in JSX components#13820
graphite-app[bot] merged 1 commit intomainfrom
c/09-16-test_linter_no-unused-vars_add_test_for_non_ascii_chars_in_jsx_components

camc314 commented Sep 16, 2025 •

edited

Loading

Uh oh!

camc314 commented Sep 16, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Sep 16, 2025 •

edited

Loading

Uh oh!

Boshen commented Sep 16, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Comments

Conversation

camc314 commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camc314 commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #13820 will not alter performance

Summary

Footnotes

Uh oh!

Boshen commented Sep 16, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

camc314 commented Sep 16, 2025 •

edited

Loading

camc314 commented Sep 16, 2025 •

edited

Loading

codspeed-hq bot commented Sep 16, 2025 •

edited

Loading

Boshen commented Sep 16, 2025 •

edited by graphite-app bot

Loading