feat(linter): add eslint/class-methods-use-this rule by PeterCardenas · Pull Request #12977 · oxc-project/oxc

PeterCardenas · 2025-08-11T00:00:11Z

Adds the class-methods-use-this rule.

Added a bunch of tests from the eslint repo and the typescript eslint repo, without the ones that rely on particular option configurations.

Works towards #479

graphite-app · 2025-08-11T00:00:21Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

codspeed-hq · 2025-08-11T00:05:31Z

CodSpeed Instrumentation Performance Report

Merging #12977 will not alter performance

_{Comparing PeterCardenas:class-methods-use-this (10a26af) with main (ca4a081)}

Summary

✅ 37 untouched

huangtiandi1999

I think we can simplify the implementation a bit. I’ve left two comments for changes, and need @camc314 to confirm them.

crates/oxc_linter/src/rules/eslint/class_methods_use_this.rs

PeterCardenas · 2025-08-12T03:57:59Z

@huangtiandi1999 fixed in latest commit! code is much easier to reason about now and was able to figure out the last few test cases as well.

crates/oxc_linter/src/rules/eslint/class_methods_use_this.rs

crates/oxc_linter/src/lib.rs

crates/oxc_linter/src/rules/eslint/class_methods_use_this.rs

camc314

thanks!

Copilot

Pull Request Overview

This PR implements the ESLint class-methods-use-this rule for the Oxc linter. The rule enforces that class methods utilize the this keyword, helping identify methods that could be converted to static methods for better performance and clarity.

Key changes implemented:

Added comprehensive rule logic with configuration options for method exceptions, class field enforcement, override method handling, and interface implementation handling
Implemented AST visitor pattern to detect this usage within method bodies while properly handling scope boundaries
Added extensive test coverage with 422 test cases covering various method types and edge cases

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
`crates/oxc_linter/src/rules/eslint/class_methods_use_this.rs`	Main rule implementation with configuration parsing, AST analysis, and comprehensive test suite
`crates/oxc_linter/src/rules.rs`	Module registration for the new rule
`crates/oxc_linter/src/snapshots/eslint_class_methods_use_this.snap`	Snapshot test output showing diagnostic messages for various failing test cases

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.}

crates/oxc_linter/src/rules/eslint/class_methods_use_this.rs

PeterCardenas · 2025-09-15T05:59:26Z

@camc314 gentle bump, would like to see this merged 🙏

camc314 · 2025-09-15T06:00:44Z

@camc314 gentle bump, would like to see this merged 🙏

thanks for the bump. apologies, i forgot to hit merge. will merge once my flight lands

## [1.16.0] - 2025-09-16 ### 🚀 Features - 97c8d06 linter: Add `preserve-caught-error` rule (#13748) (孔辉) - 8c19b18 linter/exhaustive-deps: Implement fixer for dep in global scope (#13783) (camc314) - 06bce8f linter/exhaustive-deps: Implement fixer for missing dep (#13782) (camc314) - a8675f4 linter: Add eslint/class-methods-use-this rule (#12977) (Peter Cardenas) - db33196 parser: Adds typescript rule for empty argument list (#13730) (Karan Kiri) - 2751193 linter: Add `eslint/no-useless-computed-key` rule (#13428) (yefan) - 9a205d1 regex-parser: Parse simple `TemplateLiterals` (#13265) (Sysix) ### 🐛 Bug Fixes - a2c91cd linter: Drop `rules` to allow mutable access to `ctx_host` in `run_external_rules` (#13832) (camc314) - 3af1e5d linter/no-unsafe-declaration-merging: Always mark first span as primary (#13830) (camc314) - 1c43c7c linter: Keep message when merging composite fixes (#13827) (camc314) - 26af302 linter/exhaustive-deps: Check stable value is on lhs of assignment expr (#13815) (camc314) - 4bc12d0 linter/exhaustive-deps: Remove impossible comparison with parent kind (#13814) (camc314) - 12baf5e linter/exhaustive-deps: Respect primary span when identifying disable directive location (#13781) (camc314) - fa7400a linter/no-undef: False positive with `arguments` in functions (#13763) (camc314) - 50e6e3c editor: Restrict servers paths for `oxc.path.server` (#13740) (Sysix) - b45077d editor: Strip leading slash for bin path on windows (#13738) (Sysix) - 8fa6227 editor: Don't allow `oxc.path.server` for untrusted workspaces (#13734) (Sysix) - 56da114 linter/react/jsx-handler-names: Do not detect the function name within the inline-function's body block (#13456) (Takuji Shimokawa) - b2bc5b4 linter/react-perf/jsx-no-new-object-as-prop: Skip as/satisfies exprs (#13718) (camc314) - ab51394 raw_transfer: Disable layout assertions on some 32-bit platforms (#13716) (overlookmotel) - 09428f6 linter/plugins: Remove outdated comment (#13691) (overlookmotel) - a294721 linter/plugins: Exit early if JS plugins enabled on unsupported platforms (#13689) (overlookmotel) - 68a2280 linter/plugins: More graceful exit for `--experimental-js-plugins` CLI option (#13688) (overlookmotel) ### 🚜 Refactor - 395d40d linter: Derive inmpls for `PartialEq`, `Eq` over manual ones (#13828) (camc314) - 8e4cd8f linter/func-names: Use `run_once` over looping over all nodes (#13798) (camc314) - 7f4e2fe eslint/func-names: Clean up implementation and improve documentation (#13601) (Antoine Zanardi) - 137896a language_server: Split options for linting and formatting (#13627) (Sysix) - 7346099 linter: Move `oxlint` application code into separate module (#13745) (overlookmotel) - 6dd4107 linter: Remove `#[cfg(test)]` attributes from `tester` module (#13714) (overlookmotel) - c40c6ef linter/plugins: Directory for JS plugins-related code (#13701) (overlookmotel) - a0022c1 linter/plugins: Improve error messages for JS plugins (#13699) (overlookmotel) - 1fd993f napi/oxlint: Rename `napi/oxlint2` to `napi/oxlint` (#13682) (overlookmotel) ### ⚡ Performance - 90c8286 linter: Detect node types from `let..else` statements (#13690) (camchenry) - 08c05df semantic: Make CFG construction a compile-time feature (#13678) (Boshen) ### 🎨 Styling - 99a7638 linter: Add comments + re-organise imports (#13715) (overlookmotel) ### 🧪 Testing - 18a1145 linter: Add debug assertions for skipping rules (#13724) (camc314) - cb080de linter/no-unused-vars: Add test for non ASCII chars in JSX components (#13820) (camc314) - b6eba27 linter/no-undef: Add more test cases for `arguments` (#13764) (camc314) - fb2d087 linter: Set CWD for tests (#13722) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

PeterCardenas requested a review from camc314 as a code owner August 11, 2025 00:00

github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Aug 11, 2025

PeterCardenas force-pushed the class-methods-use-this branch from 6926f50 to b548897 Compare August 11, 2025 01:34

huangtiandi1999 reviewed Aug 11, 2025

View reviewed changes

crates/oxc_linter/src/rules/eslint/class_methods_use_this.rs Outdated Show resolved Hide resolved

crates/oxc_linter/src/rules/eslint/class_methods_use_this.rs Outdated Show resolved Hide resolved

graphite-app bot reviewed Aug 12, 2025

View reviewed changes

crates/oxc_linter/src/rules/eslint/class_methods_use_this.rs Show resolved Hide resolved

crates/oxc_linter/src/rules/eslint/class_methods_use_this.rs Show resolved Hide resolved

PeterCardenas requested a review from huangtiandi1999 August 12, 2025 04:03

PeterCardenas force-pushed the class-methods-use-this branch from b1c8e83 to a422933 Compare August 12, 2025 05:30

camc314 reviewed Aug 13, 2025

View reviewed changes

crates/oxc_linter/src/rules/eslint/class_methods_use_this.rs Outdated Show resolved Hide resolved

PeterCardenas commented Aug 14, 2025

View reviewed changes

crates/oxc_linter/src/lib.rs Outdated Show resolved Hide resolved

camc314 reviewed Aug 14, 2025

View reviewed changes

crates/oxc_linter/src/rules/eslint/class_methods_use_this.rs Outdated Show resolved Hide resolved

camc314 approved these changes Aug 14, 2025

View reviewed changes

camc314 requested review from Copilot and removed request for huangtiandi1999 August 14, 2025 16:41

Copilot AI reviewed Aug 14, 2025

View reviewed changes

crates/oxc_linter/src/rules/eslint/class_methods_use_this.rs Show resolved Hide resolved

Boshen assigned camc314 Aug 26, 2025

PeterCardenas added 5 commits September 15, 2025 17:06

feat(linter): add eslint/class-methods-use-this rule

0c644ab

fix: use visitor pattern and fix failing tests

cbcfbb4

feat(linter): add options for class-methods-use-this rule

689bad2

fix: ci

1657dc4

fix: do not regress RulesEnum size

14f30ad

camc314 force-pushed the class-methods-use-this branch from 7a92472 to 14f30ad Compare September 15, 2025 09:06

fix

10a26af

camc314 approved these changes Sep 15, 2025

View reviewed changes

camc314 merged commit a8675f4 into oxc-project:main Sep 15, 2025
25 checks passed

This was referenced Sep 16, 2025

release(oxlint): v1.16.0 #13831

Closed

release(oxlint): v1.16.0 #13833

Merged

Uh oh!

Comments

Conversation

PeterCardenas commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Aug 11, 2025

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #12977 will not alter performance

Summary

Uh oh!

huangtiandi1999 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

PeterCardenas commented Aug 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

camc314 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

PeterCardenas commented Sep 15, 2025

Uh oh!

camc314 commented Sep 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

PeterCardenas commented Aug 11, 2025 •

edited

Loading

codspeed-hq bot commented Aug 11, 2025 •

edited

Loading