perf(codegen): reduce branches when printing ObjectProperty and BindingProperty

[overlookmotel]

Small optimization to codegen. It's not possible for a property to be both computed and shorthand, so only check if !shorthand once, and skip all other key-related code if shorthand == true.

(came across this while working on #13638)

[overlookmotel]

• perf(codegen): reduce branches when printing ObjectProperty and BindingProperty #13659 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #13659 will not alter performance

_{Comparing 09-10-perf_codegen_reduce_branches_when_printing_objectproperty_and_bindingproperty_ (641b252) with main (d3be692)¹}

Summary

✅ 37 untouched benchmarks

Footnotes

1. No successful run was found on main (641b252) during the generation of this report, so d3be692 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[Copilot]

Pull Request Overview

This PR optimizes the codegen performance by reducing redundant branching in ObjectProperty and BindingProperty implementations. The key insight is that a property cannot be both computed and shorthand simultaneously, allowing for more efficient conditional logic.

• Consolidates duplicate computed checks within the !shorthand branch
• Eliminates redundant branching by nesting computed conditions inside !shorthand checks
• Maintains identical output behavior while reducing code paths

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Boshen]

Merge activity

• Sep 11, 12:11 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Sep 11, 12:11 AM UTC: Boshen added this pull request to the Graphite merge queue.
• Sep 11, 12:17 AM UTC: Merged by the Graphite merge queue.