fix(codegen): use backticks for computed object property keys in destructuring assignments

[overlookmotel]

Follow-on after #13631.

That PR fixed a bug where codegen generated invalid code like ({`my-key`: value} = obj), by using normal quotes instead of backticks ({"my-key": value}).

However, it went too far. Backticks are fine when the key is computed e.g. ({[`my-key`]: value} = obj). This PR reverts to original behavior of allowing backticks in computed keys.

[overlookmotel]

• fix(codegen): use backticks for computed object property keys in destructuring assignments #13638 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

This PR fixes a codegen issue where computed object property keys in destructuring assignments were incorrectly using double quotes instead of backticks. The change reverts to allowing backticks for computed keys while maintaining the fix for non-computed keys.

• Simplified conditional logic in AssignmentTargetPropertyProperty to only handle non-computed string literals specially
• Updated test expectation to use backticks for computed property keys
• Preserves the original fix that prevents invalid syntax like ({my-key: value} = obj)

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
crates/oxc_codegen/src/gen.rs	Simplified string literal handling to only apply special quote rules for non-computed keys
crates/oxc_codegen/tests/integration/js.rs	Updated test expectation to verify backticks are used in computed property keys

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #13638 will not alter performance

_{Comparing 09-10-fix_codegen_use_backticks_for_computed_object_property_keys_in_destructuring_assignments (de9e74b) with main (9fa551a)}

Summary

✅ 37 untouched benchmarks

[sapphi-red]

Currently, ({ ["test-key"]: key }); and (class { ["test-key"] = key }); uses double quotes. If we are going to use backticks for ({["computed"]:a}=obj), I think we need to use backticks for them as well, otherwise I guess the gzip ratio would be degraded.

[overlookmotel]

Good point! I'll check if it'd be quick to change the other computed key cases. If so, I'll update this PR. If it's going to be time-consuming, I'll just close it.

[overlookmotel]

I looked into it. There's loads of places where computed keys are printed with " quotes, in preference to backticks.

Ideally I think we'd switch them all to use backticks, but that'd be more work than its worth right now. In meantime, as @sapphi-red pointed out, being consistent is the best for compression. So closing this.