Skip to content

perf(semantic): speed up Scoping::clone_in_with_semantic_ids_with_another_arena#13563

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-03-perf_semantic_speed_up_scoping_clone_in_with_semantic_ids_with_another_arena_
Sep 6, 2025
Merged

perf(semantic): speed up Scoping::clone_in_with_semantic_ids_with_another_arena#13563
graphite-app[bot] merged 1 commit intomainfrom
09-03-perf_semantic_speed_up_scoping_clone_in_with_semantic_ids_with_another_arena_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 6, 2025

Use the improved CloneIn implementations for oxc_allocator::HashMap and Vec (#13562 and #13506) to speed up cloning Scoping.

@github-actions github-actions bot added A-semantic Area - Semantic C-performance Category - Solution not expected to change functional behavior, only performance labels Sep 6, 2025
Copy link
Member Author

overlookmotel commented Sep 6, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 6, 2025

CodSpeed Instrumentation Performance Report

Merging #13563 will not alter performance

Comparing 09-03-perf_semantic_speed_up_scoping_clone_in_with_semantic_ids_with_another_arena_ (5648b31) with main (26ab087)1

Summary

✅ 37 untouched benchmarks

Footnotes

  1. No successful run was found on main (5648b31) during the generation of this report, so 26ab087 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@overlookmotel overlookmotel force-pushed the 09-04-feat_allocator_implement_clonein_for_hashmap_ branch from 9297f7c to cffa2ba Compare September 6, 2025 11:39
@overlookmotel overlookmotel force-pushed the 09-03-perf_semantic_speed_up_scoping_clone_in_with_semantic_ids_with_another_arena_ branch from 9ac6ea2 to 05fe363 Compare September 6, 2025 11:39
@overlookmotel overlookmotel marked this pull request as ready for review September 6, 2025 11:45
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 6, 2025
Copy link
Member

Boshen commented Sep 6, 2025

Merge activity

…other_arena` (#13563)

Use the improved `CloneIn` implementations for `oxc_allocator::HashMap` and `Vec` (#13562 and #13506) to speed up cloning `Scoping`.
@graphite-app graphite-app bot force-pushed the 09-04-feat_allocator_implement_clonein_for_hashmap_ branch from cffa2ba to bb1faf9 Compare September 6, 2025 17:26
@graphite-app graphite-app bot force-pushed the 09-03-perf_semantic_speed_up_scoping_clone_in_with_semantic_ids_with_another_arena_ branch from 05fe363 to 5648b31 Compare September 6, 2025 17:26
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 6, 2025
Base automatically changed from 09-04-feat_allocator_implement_clonein_for_hashmap_ to main September 6, 2025 17:31
@graphite-app graphite-app bot merged commit 5648b31 into main Sep 6, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 09-03-perf_semantic_speed_up_scoping_clone_in_with_semantic_ids_with_another_arena_ branch September 6, 2025 17:32
Copilot AI pushed a commit that referenced this pull request Sep 8, 2025
…other_arena` (#13563)

Use the improved `CloneIn` implementations for `oxc_allocator::HashMap` and `Vec` (#13562 and #13506) to speed up cloning `Scoping`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants