Skip to content

Comments

feat(allocator): implement CloneIn for HashMap#13562

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-04-feat_allocator_implement_clonein_for_hashmap_
Sep 6, 2025
Merged

feat(allocator): implement CloneIn for HashMap#13562
graphite-app[bot] merged 1 commit intomainfrom
09-04-feat_allocator_implement_clonein_for_hashmap_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 6, 2025

Implement CloneIn for oxc_allocator::HashMap, to match the implementations for Vec and Box.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Sep 6, 2025
Copy link
Member Author

overlookmotel commented Sep 6, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 6, 2025

CodSpeed Instrumentation Performance Report

Merging #13562 will not alter performance

Comparing 09-04-feat_allocator_implement_clonein_for_hashmap_ (bb1faf9) with main (26ab087)1

Summary

✅ 37 untouched benchmarks

Footnotes

  1. No successful run was found on main (bb1faf9) during the generation of this report, so 26ab087 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@overlookmotel overlookmotel force-pushed the 08-30-perf_allocator_remove_bounds_checks_in_clonein_for_vec_ branch from 03e4497 to 4839e25 Compare September 6, 2025 11:39
@overlookmotel overlookmotel force-pushed the 09-04-feat_allocator_implement_clonein_for_hashmap_ branch from 9297f7c to cffa2ba Compare September 6, 2025 11:39
@overlookmotel overlookmotel marked this pull request as ready for review September 6, 2025 11:42
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Sep 6, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 6, 2025

Merge activity

Implement `CloneIn` for `oxc_allocator::HashMap`, to match the implementations for `Vec` and `Box`.
@graphite-app graphite-app bot force-pushed the 08-30-perf_allocator_remove_bounds_checks_in_clonein_for_vec_ branch from 4839e25 to 6fce49d Compare September 6, 2025 17:25
@graphite-app graphite-app bot force-pushed the 09-04-feat_allocator_implement_clonein_for_hashmap_ branch from cffa2ba to bb1faf9 Compare September 6, 2025 17:26
graphite-app bot pushed a commit that referenced this pull request Sep 6, 2025
…other_arena` (#13563)

Use the improved `CloneIn` implementations for `oxc_allocator::HashMap` and `Vec` (#13562 and #13506) to speed up cloning `Scoping`.
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 6, 2025
Base automatically changed from 08-30-perf_allocator_remove_bounds_checks_in_clonein_for_vec_ to main September 6, 2025 17:31
@graphite-app graphite-app bot merged commit bb1faf9 into main Sep 6, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 09-04-feat_allocator_implement_clonein_for_hashmap_ branch September 6, 2025 17:31
Copilot AI pushed a commit that referenced this pull request Sep 8, 2025
Implement `CloneIn` for `oxc_allocator::HashMap`, to match the implementations for `Vec` and `Box`.
Copilot AI pushed a commit that referenced this pull request Sep 8, 2025
…other_arena` (#13563)

Use the improved `CloneIn` implementations for `oxc_allocator::HashMap` and `Vec` (#13562 and #13506) to speed up cloning `Scoping`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant