perf(allocator/bitset): store bits in Box<[usize]>#13455
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 31, 2025
Merged
perf(allocator/bitset): store bits in Box<[usize]>#13455graphite-app[bot] merged 1 commit intomainfrom
Box<[usize]>#13455graphite-app[bot] merged 1 commit intomainfrom
Conversation
This was referenced Aug 30, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #13455 will not alter performanceComparing Summary
Footnotes
|
cd9ac84 to
ff29042
Compare
Box<[usize]>Box<[usize]>
ff29042 to
450d77c
Compare
Member
Merge activity
|
a277732 to
e3b6dc0
Compare
450d77c to
ba1f575
Compare
`BitSet` store data in a `Box<[usize]>` instead of `Vec<usize>`. This has 2 advantages: 1. `Box<[usize]>` is smaller - 16 bytes vs 24 for `Vec<usize>`. 2. Marginally faster to initialize. Also, improve the implementation of `BitSet::clone_in` to avoid bounds checks. As `usize` is `Copy`, we can just use `ptr::copy_nonoverlapping` to copy the whole slice in one go, instead of cloning entries one by one.
ba1f575 to
b92fa4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

BitSetstore data in aBox<[usize]>instead ofVec<usize>. This has 2 advantages:Box<[usize]>is smaller - 16 bytes vs 24 forVec<usize>.Also, improve the implementation of
BitSet::clone_into avoid bounds checks. AsusizeisCopy, we can just useptr::copy_nonoverlappingto copy the whole slice in one go, instead of cloning entries one by one.