Skip to content

feat(allocator): add Box::from_non_null method#13454

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-30-feat_allocator_add_box_from_non_null_method
Aug 31, 2025
Merged

feat(allocator): add Box::from_non_null method#13454
graphite-app[bot] merged 1 commit intomainfrom
08-30-feat_allocator_add_box_from_non_null_method

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 30, 2025

Add an unsafe method Box::from_non_null which creates a Box from a pointer.

Copy link
Member Author

overlookmotel commented Aug 30, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 30, 2025

CodSpeed Instrumentation Performance Report

Merging #13454 will degrade performances by 3.55%

Comparing 08-30-feat_allocator_add_box_from_non_null_method (e3b6dc0) with main (edeebc6)1

Summary

⚡ 3 improvements
❌ 1 regressions
✅ 33 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[RadixUIAdoptionSection.jsx] 11.7 µs 12.1 µs -3.55%
mangler[binder.ts] 895 µs 793.8 µs +12.75%
mangler[cal.com.tsx] 4.1 ms 2.9 ms +38.51%
mangler[react.development.js] 292.8 µs 276.4 µs +5.93%

Footnotes

  1. No successful run was found on main (e3b6dc0) during the generation of this report, so edeebc6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@overlookmotel overlookmotel marked this pull request as ready for review August 30, 2025 21:49
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Aug 31, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 31, 2025

Merge activity

Add an unsafe method `Box::from_non_null` which creates a `Box` from a pointer.
@graphite-app graphite-app bot force-pushed the 08-30-perf_allocator_bitset_initialize_bitset_with_memset_ branch from 21aa26b to f5a742f Compare August 31, 2025 05:00
@graphite-app graphite-app bot force-pushed the 08-30-feat_allocator_add_box_from_non_null_method branch from a277732 to e3b6dc0 Compare August 31, 2025 05:01
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 31, 2025
Base automatically changed from 08-30-perf_allocator_bitset_initialize_bitset_with_memset_ to main August 31, 2025 05:05
@graphite-app graphite-app bot merged commit e3b6dc0 into main Aug 31, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 08-30-feat_allocator_add_box_from_non_null_method branch August 31, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant