Skip to content

refactor(data_structures)!: rename SliceIterExt to SliceIter#13439

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-30-refactor_data_structures_rename_sliceiterext_to_sliceiter_
Aug 31, 2025
Merged

refactor(data_structures)!: rename SliceIterExt to SliceIter#13439
graphite-app[bot] merged 1 commit intomainfrom
08-30-refactor_data_structures_rename_sliceiterext_to_sliceiter_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 30, 2025 •
edited
Loading

Pure refactor. Rename:

  • SliceIterExt -> SliceIter
  • SliceIterMutExt -> SliceIterMut
  • slice_iter_ext module -> slice_iter
  • slice_iter_ext Cargo feature -> slice_iter

I don't think "ext" added any value. There is no SliceIter trait in std library, so no naming clash.

This was referenced Aug 30, 2025
Merged
Merged
Merged
Merged
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Aug 30, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Aug 30, 2025
Merged
@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler A-codegen Area - Code Generation C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 30, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 30, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #13439 will not alter performance

Comparing 08-30-refactor_data_structures_rename_sliceiterext_to_sliceiter_ (edeebc6) with 08-30-perf_data_structures_reduce_itermut_advance_unchecked_to_1_instruction (475205f)

Summary

✅ 37 untouched benchmarks

@overlookmotel overlookmotel marked this pull request as ready for review August 30, 2025 16:48
@overlookmotel overlookmotel requested a review from Dunqing as a code owner August 30, 2025 16:48
@overlookmotel overlookmotel force-pushed the 08-30-refactor_data_structures_rename_sliceiterext_to_sliceiter_ branch from 646599e to e7cd71f Compare August 30, 2025 17:31
@overlookmotel overlookmotel force-pushed the 08-30-perf_data_structures_reduce_itermut_advance_unchecked_to_1_instruction branch from 361cd34 to b7c88ce Compare August 30, 2025 17:31
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 30, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Aug 30, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Aug 30, 10:13 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 30, 10:33 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Aug 30, 11:08 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #13435.
  • Aug 31, 12:27 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 31, 12:37 AM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Aug 31, 12:37 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #13437.
  • Aug 31, 12:37 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #13437.
  • Aug 31, 12:46 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 31, 12:51 AM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Aug 31, 12:52 AM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 08-30-perf_data_structures_reduce_itermut_advance_unchecked_to_1_instruction branch from b7c88ce to e2940ef Compare August 30, 2025 22:34
graphite-app bot pushed a commit that referenced this pull request Aug 30, 2025
@overlookmotel
refactor(data_structures)!: rename SliceIterExt to SliceIter (#13439
175a7a5 
)

Pure refactor. Rename:

* `SliceIterExt` -> `SliceIter`
* `SliceIterMutExt` -> `SliceIterMut`
* `slice_iter_ext` module -> `slice_iter`
* `slice_iter_ext` Cargo feature -> `slice_iter`

I don't think "ext" added any value. There is no `SliceIter` trait in std library, so no naming clash.
@graphite-app graphite-app bot force-pushed the 08-30-refactor_data_structures_rename_sliceiterext_to_sliceiter_ branch from e7cd71f to 175a7a5 Compare August 30, 2025 22:35
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 30, 2025
overlookmotel added a commit that referenced this pull request Aug 31, 2025
@overlookmotel
refactor(data_structures)!: rename SliceIterExt to SliceIter (#13439
6865883 
)

Pure refactor. Rename:

* `SliceIterExt` -> `SliceIter`
* `SliceIterMutExt` -> `SliceIterMut`
* `slice_iter_ext` module -> `slice_iter`
* `slice_iter_ext` Cargo feature -> `slice_iter`

I don't think "ext" added any value. There is no `SliceIter` trait in std library, so no naming clash.
@overlookmotel overlookmotel force-pushed the 08-30-perf_data_structures_reduce_itermut_advance_unchecked_to_1_instruction branch from e2940ef to 5661ccd Compare August 31, 2025 00:25
@overlookmotel overlookmotel force-pushed the 08-30-refactor_data_structures_rename_sliceiterext_to_sliceiter_ branch from 175a7a5 to 6865883 Compare August 31, 2025 00:25
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 31, 2025
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 31, 2025
@overlookmotel
refactor(data_structures)!: rename SliceIterExt to SliceIter (#13439
edeebc6 
)

Pure refactor. Rename:

* `SliceIterExt` -> `SliceIter`
* `SliceIterMutExt` -> `SliceIterMut`
* `slice_iter_ext` module -> `slice_iter`
* `slice_iter_ext` Cargo feature -> `slice_iter`

I don't think "ext" added any value. There is no `SliceIter` trait in std library, so no naming clash.
@overlookmotel overlookmotel force-pushed the 08-30-refactor_data_structures_rename_sliceiterext_to_sliceiter_ branch from 6865883 to edeebc6 Compare August 31, 2025 00:46
@overlookmotel overlookmotel force-pushed the 08-30-perf_data_structures_reduce_itermut_advance_unchecked_to_1_instruction branch from 5661ccd to 475205f Compare August 31, 2025 00:46
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 31, 2025
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 31, 2025
Base automatically changed from 08-30-perf_data_structures_reduce_itermut_advance_unchecked_to_1_instruction to main August 31, 2025 00:52
@graphite-app graphite-app bot merged commit edeebc6 into main Aug 31, 2025
32 of 51 checks passed
@graphite-app graphite-app bot deleted the 08-30-refactor_data_structures_rename_sliceiterext_to_sliceiter_ branch August 31, 2025 00:52
@oxc-bot oxc-bot mentioned this pull request Aug 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 camc314 approved these changes

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees

No one assigned

Labels

A-codegen Area - Code Generation A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel @camc314