feat(data_structures): add ptr and end_ptr methods to SliceIterExt#13435
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 31, 2025
Conversation
github-actions
bot
added
A-codegen
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #13435 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
08-30-feat_data_structures_add_ptr_and_end_ptr_methods_to_sliceiterext_
branch
from
403c732 to
38d92dc
Compare
overlookmotel
force-pushed
the
08-29-feat_data_structures_add_sliceiterext_peek_method
branch
from
712b35a to
e88e35c
Compare
overlookmotel
force-pushed
the
08-29-feat_data_structures_add_sliceiterext_peek_method
branch
from
e88e35c to
2b8108f
Compare
overlookmotel
force-pushed
the
08-30-feat_data_structures_add_ptr_and_end_ptr_methods_to_sliceiterext_
branch
from
38d92dc to
1f06e4c
Compare
camc314
approved these changes
Aug 30, 2025
graphite-app
bot
changed the base branch from
08-29-feat_data_structures_add_sliceiterext_peek_method
to
graphite-base/13435
Member
Author
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Aug 30, 2025
…xt` (#13435) Add `ptr` and `end_ptr` methods to `SliceIterExt`. These methods get pointers to the start and end of slice iterators, using the minimum possible number of instructions (1). `end_ptr` also avoids unsafe code, unlike `iter.as_slice().as_ptr().add(iter.as_slice().len())`, which we used previously. Use these methods in codegen.
graphite-app
bot
force-pushed
the
08-30-feat_data_structures_add_ptr_and_end_ptr_methods_to_sliceiterext_
branch
from
1f06e4c to
26adf36
Compare
graphite-app
bot
changed the base branch from
graphite-base/13435
to
08-29-feat_data_structures_add_sliceiterext_peek_method
Base automatically changed from
08-29-feat_data_structures_add_sliceiterext_peek_method
to
main
August 30, 2025 22:37
overlookmotel
force-pushed
the
08-30-feat_data_structures_add_ptr_and_end_ptr_methods_to_sliceiterext_
branch
from
26adf36 to
165de00
Compare
…xt` (#13435) Add `ptr` and `end_ptr` methods to `SliceIterExt`. These methods get pointers to the start and end of slice iterators, using the minimum possible number of instructions (1). `end_ptr` also avoids unsafe code, unlike `iter.as_slice().as_ptr().add(iter.as_slice().len())`, which we used previously. Use these methods in codegen.
graphite-app
bot
force-pushed
the
08-30-feat_data_structures_add_ptr_and_end_ptr_methods_to_sliceiterext_
branch
from
165de00 to
5b139aa
Compare
graphite-app
bot
deleted the
08-30-feat_data_structures_add_ptr_and_end_ptr_methods_to_sliceiterext_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
ptrandend_ptrmethods toSliceIterExt. These methods get pointers to the start and end of slice iterators, using the minimum possible number of instructions (1).end_ptralso avoids unsafe code, unlikeiter.as_slice().as_ptr().add(iter.as_slice().len()), which we used previously.Use these methods in codegen.