Skip to content

Comments

feat(minifier): support remaining expressions for single use variable inlining#13280

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-24-feat_minifier_support_remaining_expressions_for_single_use_variable_inlining
Aug 24, 2025
Merged

feat(minifier): support remaining expressions for single use variable inlining#13280
graphite-app[bot] merged 1 commit intomainfrom
08-24-feat_minifier_support_remaining_expressions_for_single_use_variable_inlining

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 24, 2025

Improved substitute_single_use_symbol_in_expression to support the remaining expressions.

Copy link
Member Author

sapphi-red commented Aug 24, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 24, 2025

CodSpeed Instrumentation Performance Report

Merging #13280 will degrade performances by 7.05%

Comparing 08-24-feat_minifier_support_remaining_expressions_for_single_use_variable_inlining (07afa70) with main (e7a49ed)1

Summary

❌ 1 regressions
✅ 33 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
minifier[react.development.js] 2.1 ms 2.3 ms -7.05%

Footnotes

  1. No successful run was found on 08-24-feat_ecmascript_implement_mayhavesideeffects_for_assignmenttarget (8e34656) during the generation of this report, so main (e7a49ed) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 24, 2025
Copy link
Member

Boshen commented Aug 24, 2025

Merge activity

… inlining (#13280)

Improved `substitute_single_use_symbol_in_expression` to support the remaining expressions.
graphite-app bot pushed a commit that referenced this pull request Aug 24, 2025
…13279)

Implemented `MayHaveSideEffects` for `AssignmentTarget` to use it by #13280.
@graphite-app graphite-app bot force-pushed the 08-24-feat_ecmascript_implement_mayhavesideeffects_for_assignmenttarget branch from e05e973 to 8e34656 Compare August 24, 2025 08:46
@graphite-app graphite-app bot force-pushed the 08-24-feat_minifier_support_remaining_expressions_for_single_use_variable_inlining branch from 70c06f4 to 07afa70 Compare August 24, 2025 08:47
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 24, 2025
Base automatically changed from 08-24-feat_ecmascript_implement_mayhavesideeffects_for_assignmenttarget to main August 24, 2025 08:55
@graphite-app graphite-app bot merged commit 07afa70 into main Aug 24, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 08-24-feat_minifier_support_remaining_expressions_for_single_use_variable_inlining branch August 24, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants