fix(minifier): keep property access before call expressions as-is to preserve this value

[sapphi-red]

['PASS',f][1]() was compressed to f(). But this is not safe because f may access this and the value of this changes.
This PR fixes that by skipping this transformation when the parent is a function call.

[sapphi-red]

• feat(minifier): support remaining expressions for single use variable inlining #13280
• feat(ecmascript): implement MayHaveSideEffects for AssignmentTarget #13279
• feat(minifier): support more statements for single use variable inlining #13277
• feat(minifier): support more expressions for single use variable inlining #13276
• feat(minifier): implement basic single use variable inlining #13275
• feat(minifier): remove unnecessary parenthesis from nested optional chaining #13268
• feat(minifier): remove unused assignments for vars #13231
• fix(minifier): keep variables that are modified by combined assignments made by minification #13267
• fix(minifier): keep property access before call expressions as-is to preserve this value #13278 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

This PR fixes a minification bug where property access expressions followed by function calls were being over-optimized, causing incorrect this binding. The fix prevents the transformation of expressions like ['PASS',f][1]() to f() when the property access is immediately followed by a call expression.

• Adds a guard condition to preserve property access when it's the callee of a function call or tagged template
• Includes a test case demonstrating the bug scenario with this value preservation

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #13278 will not alter performance

_{Comparing 08-24-fix_minifier_keep_property_access_before_call_expressions_as-is_to_preserve_this_value (6003285) with main (e7a49ed)¹}

Summary

✅ 34 untouched benchmarks

Footnotes

1. No successful run was found on main (6003285) during the generation of this report, so e7a49ed was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[graphite-app]

Merge activity

• Aug 24, 8:30 AM UTC: Boshen added this pull request to the Graphite merge queue.
• Aug 24, 8:48 AM UTC: Merged by the Graphite merge queue.