Skip to content

fix(oxlint): should type linting files after ignore #13149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Aug 17, 2025
Merged

fix(oxlint): should type linting files after ignore #13149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions apps/oxlint/src/lint.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,22 +291,22 @@ impl LintRunner {

let config_store = ConfigStore::new(lint_config, nested_configs, external_plugin_store);

let files_to_lint = paths
.into_iter()
.filter(|path| !config_store.should_ignore(Path::new(path)))
.collect::<Vec<Arc<OsStr>>>();

// Run type-aware linting through tsgolint
// TODO: Add a warning message if `tsgolint` cannot be found, but type-aware rules are enabled
if self.options.type_aware {
if let Err(err) = TsGoLintState::new(options.cwd(), config_store.clone())
.lint(&paths, tx_error.clone())
.lint(&files_to_lint, tx_error.clone())
{
print_and_flush_stdout(stdout, &err);
return CliRunResult::TsGoLintError;
}
}

let files_to_lint = paths
.into_iter()
.filter(|path| !config_store.should_ignore(Path::new(path)))
.collect::<Vec<Arc<OsStr>>>();

let linter = Linter::new(LintOptions::default(), config_store, self.external_linter)
.with_fix(fix_options.fix_kind())
.with_report_unused_directives(report_unused_directives);
Expand Down
Loading