Skip to content

fix(oxlint): should type linting files after ignore#13149

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-17-fix_oxlint_should_type_linting_files_after_ignore
Aug 17, 2025
Merged

fix(oxlint): should type linting files after ignore#13149
graphite-app[bot] merged 1 commit intomainfrom
08-17-fix_oxlint_should_type_linting_files_after_ignore

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Aug 17, 2025

No description provided.

Copilot AI review requested due to automatic review settings August 17, 2025 03:50
@Boshen Boshen requested a review from camc314 as a code owner August 17, 2025 03:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where type-aware linting was processing files that should have been ignored according to the configured ignore patterns. The fix ensures that file filtering is applied before type-aware linting runs.

  • Moves file filtering logic before type-aware linting execution
  • Ensures both type-aware and regular linting use the same filtered file list

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added A-cli Area - CLI C-bug Category - Bug labels Aug 17, 2025
Copy link
Member Author

Boshen commented Aug 17, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 17, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 08-17-fix_oxlint_should_type_linting_files_after_ignore branch from 1dea2e9 to 66a350e Compare August 17, 2025 03:57
@graphite-app graphite-app bot merged commit 66a350e into main Aug 17, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 08-17-fix_oxlint_should_type_linting_files_after_ignore branch August 17, 2025 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants