feat(language_server): add typeAware option

[Sysix]

related oxc-project/oxc-zed#18

[Sysix]

• refactor(linter): move lsp relevant code into own file #13243
• feat(editor): add oxc.typeAware option for workspaces #13147
• feat(language_server): add typeAware option #13146 👈 (View in Graphite)
• refactor(linter): add impl for TsGoLintDiagnostic into Message #13144
• refactor(linter): message_to_message_with_position helper function #13140
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #13146 will not alter performance

_{Comparing 08-16-feat_langauge_server_add_typeaware_option (faee1a4) with main (5d898e8)¹}

Summary

✅ 34 untouched benchmarks

Footnotes

1. No successful run was found on main (faee1a4) during the generation of this report, so 5d898e8 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[Copilot]

Pull Request Overview

Adds TypeScript type-aware linting support to the language server by integrating TsGoLint capabilities alongside the existing Oxc linter. The typeAware option enables clients to use TypeScript's type system for more sophisticated linting rules.

• Introduces new typeAware configuration option in language server options
• Adds TsgoLinter wrapper to integrate TsGoLint with the language server
• Implements streaming diagnostic processing for better performance with TsGoLint

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
crates/oxc_linter/src/tsgolint.rs	Adds lint_source method for processing single files with streaming diagnostics
crates/oxc_language_server/src/worker.rs	Updates linting conditions to restrict type-aware linting to OnSave only
crates/oxc_language_server/src/options.rs	Adds typeAware configuration option parsing and testing
crates/oxc_language_server/src/linter/tsgo_linter.rs	New wrapper for TsGoLint integration with file filtering logic
crates/oxc_language_server/src/linter/server_linter.rs	Integrates TsgoLinter with existing ServerLinter
crates/oxc_language_server/README.md	Documents the new typeAware configuration option

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Boshen]

We will probably end up adding typeAware: true config which makes this unnecessary?

[Sysix]

We will probably end up adding typeAware: true config which makes this unnecessary?

You mean enabling typeAware by default? The option could be used for disabling it. Hope the CLI will have something similar too :)

EDIT: oh I think you mean .oxlintrc.json configuration. Sorry :D. Yes, that is then unnecessary.
But I guess the same for --type-aware flag?

[camc314]

@Boshen shall we merge this, and then remove it at a later date once typeAware: true option exists in the config file?

[camc314]

@Boshen shall we merge this, and then remove it at a later date once typeAware: true option exists in the config file?

@Sysix based on this message, i think we should hold off on this until the perf/memory issues in tsgolint are addressed.

[Sysix]

@Sysix based on this message, i think we should hold off on this until the perf/memory issues in tsgolint are addressed.

I could not identify a problem with the language server. The import plugin memory problem is still valid. But typeAware should be no problem. The Process is started and closed with each diagnostic request. It is not perfect, but I do not see memory issues with it 🤔
We are always executing tsgolint with only one file.

[Sysix]

@Boshen the request for this feature is high. See the linked issues in #13147

@Boshen shall we merge this, and then remove it at a later date once typeAware: true option exists in the config file

I could not identify a problem with the language server. The import plugin memory problem is still valid. But typeAware should be no problem. The Process is started and closed with each diagnostic request. It is not perfect, but I do not see memory issues with it 🤔
We are always executing tsgolint with only one file.

[Boshen]

Merge activity

• Aug 26, 2:39 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Aug 26, 2:39 AM UTC: Boshen added this pull request to the Graphite merge queue.
• Aug 26, 2:43 AM UTC: Merged by the Graphite merge queue.