refactor(linter): add impl for TsGoLintDiagnostic into Message#13144
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #13144 will not alter performanceComparing Summary
Footnotes |
e58ff2a to
437a63d
Compare
57b80c7 to
53ca6ca
Compare
53ca6ca to
2f1514a
Compare
2f1514a to
afc7d3c
Compare
afc7d3c to
17885e4
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the linter to add conversion capability from TsGoLintDiagnostic to Message, enabling better integration between the tsgolint system and the linter's message handling. The changes introduce a trait-based approach for type conversions and make the fix merging functionality publicly accessible.
- Adds a new trait
FromTsGoLintDiagnosticfor type conversions fromTsGoLintDiagnostic - Implements the trait for
Messageto enable direct conversion with fix handling - Makes
CompositeFix::merge_fixespublic to support the new conversion functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/oxc_linter/src/tsgolint.rs | Adds trait and implementation for converting TsGoLintDiagnostic to Message with fix support |
| crates/oxc_linter/src/fixer/fix.rs | Changes visibility of merge_fixes method from private to public |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
17885e4 to
0f8e4b1
Compare
Merge activity
|
0f8e4b1 to
700b412
Compare

No description provided.