Skip to content

refactor(linter): add impl for TsGoLintDiagnostic into Message#13144

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-16-refactor_linter_add_impl_for_tsgolintdiagnostic_into_message_
Aug 16, 2025
Merged

refactor(linter): add impl for TsGoLintDiagnostic into Message#13144
graphite-app[bot] merged 1 commit intomainfrom
08-16-refactor_linter_add_impl_for_tsgolintdiagnostic_into_message_

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Aug 16, 2025

No description provided.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 16, 2025
Copy link
Member Author

Sysix commented Aug 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 16, 2025

CodSpeed Instrumentation Performance Report

Merging #13144 will not alter performance

Comparing 08-16-refactor_linter_add_impl_for_tsgolintdiagnostic_into_message_ (700b412) with main (c63c944)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (700b412) during the generation of this report, so c63c944 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@graphite-app graphite-app bot changed the base branch from 08-16-refactor_linter_message_to_message_with_position_helper_function to graphite-base/13144 August 16, 2025 14:30
@graphite-app graphite-app bot force-pushed the graphite-base/13144 branch from e58ff2a to 437a63d Compare August 16, 2025 14:40
@graphite-app graphite-app bot force-pushed the 08-16-refactor_linter_add_impl_for_tsgolintdiagnostic_into_message_ branch from 57b80c7 to 53ca6ca Compare August 16, 2025 14:40
@graphite-app graphite-app bot changed the base branch from graphite-base/13144 to main August 16, 2025 14:40
@graphite-app graphite-app bot force-pushed the 08-16-refactor_linter_add_impl_for_tsgolintdiagnostic_into_message_ branch from 53ca6ca to 2f1514a Compare August 16, 2025 14:41
@Sysix Sysix force-pushed the 08-16-refactor_linter_add_impl_for_tsgolintdiagnostic_into_message_ branch from 2f1514a to afc7d3c Compare August 16, 2025 16:31
@Sysix Sysix force-pushed the 08-16-refactor_linter_add_impl_for_tsgolintdiagnostic_into_message_ branch from afc7d3c to 17885e4 Compare August 16, 2025 18:11
@Sysix Sysix marked this pull request as ready for review August 16, 2025 18:12
Copilot AI review requested due to automatic review settings August 16, 2025 18:12
@Sysix Sysix requested a review from camc314 as a code owner August 16, 2025 18:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the linter to add conversion capability from TsGoLintDiagnostic to Message, enabling better integration between the tsgolint system and the linter's message handling. The changes introduce a trait-based approach for type conversions and make the fix merging functionality publicly accessible.

  • Adds a new trait FromTsGoLintDiagnostic for type conversions from TsGoLintDiagnostic
  • Implements the trait for Message to enable direct conversion with fix handling
  • Makes CompositeFix::merge_fixes public to support the new conversion functionality

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
crates/oxc_linter/src/tsgolint.rs Adds trait and implementation for converting TsGoLintDiagnostic to Message with fix support
crates/oxc_linter/src/fixer/fix.rs Changes visibility of merge_fixes method from private to public

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Sysix Sysix force-pushed the 08-16-refactor_linter_add_impl_for_tsgolintdiagnostic_into_message_ branch from 17885e4 to 0f8e4b1 Compare August 16, 2025 18:18
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Aug 16, 2025
Copy link
Contributor

camc314 commented Aug 16, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 08-16-refactor_linter_add_impl_for_tsgolintdiagnostic_into_message_ branch from 0f8e4b1 to 700b412 Compare August 16, 2025 20:17
@graphite-app graphite-app bot merged commit 700b412 into main Aug 16, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 08-16-refactor_linter_add_impl_for_tsgolintdiagnostic_into_message_ branch August 16, 2025 20:21
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants