refactor(linter): pass cwd instead of LintServiceOptions into TsGoLintState#13127
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #13127 will not alter performanceComparing Summary
Footnotes |
871077e to
e065911
Compare
LintServiceOptionsLintServiceOptions into TsGoLintState
There was a problem hiding this comment.
Pull Request Overview
This refactor simplifies the TsGoLintState constructor by passing only the current working directory (cwd) parameter instead of the entire LintServiceOptions struct, reducing coupling between components.
- Refactored
TsGoLintState::new()to acceptcwd: &Pathparameter instead ofLintServiceOptions - Updated the call site in
lint.rsto passoptions.cwd()directly - Removed unused import of
LintServiceOptions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/oxc_linter/src/tsgolint.rs | Simplified constructor to accept only cwd parameter and removed LintServiceOptions import |
| apps/oxlint/src/lint.rs | Updated function call to pass options.cwd() directly to the refactored constructor |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Merge activity
|
e065911 to
15cb57c
Compare
15cb57c to
f0a517f
Compare

No description provided.