Skip to content

refactor(linter): pass cwd instead of LintServiceOptions into TsGoLintState#13127

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-15-refactor_linter_pass_cwd_instead_of_lintserviceoptions_
Aug 15, 2025
Merged

refactor(linter): pass cwd instead of LintServiceOptions into TsGoLintState#13127
graphite-app[bot] merged 1 commit intomainfrom
08-15-refactor_linter_pass_cwd_instead_of_lintserviceoptions_

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Aug 15, 2025

No description provided.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 15, 2025
Copy link
Member Author

Sysix commented Aug 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix marked this pull request as ready for review August 15, 2025 17:41
@Sysix Sysix requested a review from camc314 as a code owner August 15, 2025 17:41
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 15, 2025

CodSpeed Instrumentation Performance Report

Merging #13127 will not alter performance

Comparing 08-15-refactor_linter_pass_cwd_instead_of_lintserviceoptions_ (f0a517f) with main (b638371)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (f0a517f) during the generation of this report, so b638371 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Sysix Sysix force-pushed the 08-15-refactor_linter_pass_cwd_instead_of_lintserviceoptions_ branch from 871077e to e065911 Compare August 15, 2025 18:28
@Sysix Sysix changed the title refactor(linter): pass cwd instead of LintServiceOptions refactor(linter): pass cwd instead of LintServiceOptions into TsGoLintState Aug 15, 2025
@graphite-app graphite-app bot changed the base branch from 08-15-refactor_linter_move_tsgolint.rs_to_oxc_linter_crate to graphite-base/13127 August 15, 2025 22:13
@camc314 camc314 requested a review from Copilot August 15, 2025 22:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This refactor simplifies the TsGoLintState constructor by passing only the current working directory (cwd) parameter instead of the entire LintServiceOptions struct, reducing coupling between components.

  • Refactored TsGoLintState::new() to accept cwd: &Path parameter instead of LintServiceOptions
  • Updated the call site in lint.rs to pass options.cwd() directly
  • Removed unused import of LintServiceOptions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/oxc_linter/src/tsgolint.rs Simplified constructor to accept only cwd parameter and removed LintServiceOptions import
apps/oxlint/src/lint.rs Updated function call to pass options.cwd() directly to the refactored constructor

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Aug 15, 2025
Copy link
Contributor

camc314 commented Aug 15, 2025

Merge activity

  • Aug 15, 10:14 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 15, 10:14 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Aug 15, 10:19 PM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
  • Aug 15, 10:20 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Aug 15, 10:25 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Aug 15, 10:30 PM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from graphite-base/13127 to main August 15, 2025 22:18
@graphite-app graphite-app bot added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Aug 15, 2025
@camc314 camc314 force-pushed the 08-15-refactor_linter_pass_cwd_instead_of_lintserviceoptions_ branch from e065911 to 15cb57c Compare August 15, 2025 22:20
@graphite-app graphite-app bot force-pushed the 08-15-refactor_linter_pass_cwd_instead_of_lintserviceoptions_ branch from 15cb57c to f0a517f Compare August 15, 2025 22:25
@graphite-app graphite-app bot merged commit f0a517f into main Aug 15, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 08-15-refactor_linter_pass_cwd_instead_of_lintserviceoptions_ branch August 15, 2025 22:30
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants