Skip to content

refactor(linter): move tsgolint.rs to oxc_linter crate#13126

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-15-refactor_linter_move_tsgolint.rs_to_oxc_linter_crate
Aug 15, 2025
Merged

refactor(linter): move tsgolint.rs to oxc_linter crate#13126
graphite-app[bot] merged 1 commit intomainfrom
08-15-refactor_linter_move_tsgolint.rs_to_oxc_linter_crate

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Aug 15, 2025

The language server wants type aware feature too ❤️

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 15, 2025
Copy link
Member Author

Sysix commented Aug 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix marked this pull request as ready for review August 15, 2025 17:01
Copilot AI review requested due to automatic review settings August 15, 2025 17:01
@Sysix Sysix requested a review from camc314 as a code owner August 15, 2025 17:01
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 15, 2025

CodSpeed Instrumentation Performance Report

Merging #13126 will not alter performance

Comparing 08-15-refactor_linter_move_tsgolint.rs_to_oxc_linter_crate (34ae2f0) with main (51f6c84)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (34ae2f0) during the generation of this report, so 51f6c84 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the codebase by moving tsgolint.rs from the apps/oxlint crate to the oxc_linter crate to improve code organization and modularity.

  • Relocated tsgolint.rs module from application layer to library layer
  • Updated import statements to use relative imports within the new crate
  • Added proper documentation comments to the lint method

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
crates/oxc_linter/src/tsgolint.rs Updated imports to use relative paths and added comprehensive documentation for the lint method
crates/oxc_linter/src/lib.rs Added tsgolint module declaration and exported TsGoLintState type
apps/oxlint/src/lint.rs Updated import to use TsGoLintState from oxc_linter crate instead of local module
apps/oxlint/src/lib.rs Removed tsgolint module declaration as it's now moved to oxc_linter

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Sysix Sysix force-pushed the 08-15-refactor_linter_move_tsgolint.rs_to_oxc_linter_crate branch from 6572250 to de0b08a Compare August 15, 2025 17:04
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Aug 15, 2025
Copy link
Contributor

camc314 commented Aug 15, 2025

Merge activity

The language server wants type aware feature too ❤️
@graphite-app graphite-app bot force-pushed the 08-15-refactor_linter_move_tsgolint.rs_to_oxc_linter_crate branch from de0b08a to 34ae2f0 Compare August 15, 2025 22:13
@graphite-app graphite-app bot merged commit 34ae2f0 into main Aug 15, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 08-15-refactor_linter_move_tsgolint.rs_to_oxc_linter_crate branch August 15, 2025 22:18
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants