refactor(transformer/object-rest-spread): extract unboxed field earlier#12717
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 1, 2025
Conversation
github-actions
bot
added
A-transformer
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #12717 will not alter performanceComparing Summary
|
Dunqing
approved these changes
Aug 1, 2025
Member
Dunqing
left a comment
Dunqing
left a comment
There was a problem hiding this comment.
I've noticed this before, but Boshen merged that PR so quickly.
Member
Merge activity
|
graphite-app
bot
force-pushed
the
08-01-refactor_parser_shorten_astbuilder_calls
branch
from
f7a5f41 to
8a27974
Compare
graphite-app
bot
force-pushed
the
08-01-refactor_transformer_object-rest-spread_extract_unboxed_field_earlier
branch
from
8910d94 to
5c9fdd2
Compare
Base automatically changed from
08-01-refactor_parser_shorten_astbuilder_calls
to
main
August 1, 2025 11:16
graphite-app
bot
deleted the
08-01-refactor_transformer_object-rest-spread_extract_unboxed_field_earlier
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor. Follow-on after #12698.
We only need the
targetfield, so no need bring the whole ofAssignmentTargetRestonto the stack. Possibly compiler will have optimized this already, but better to be explicit and make it easier for compiler to apply the optimization.