Skip to content

Comments

refactor(parser): shorten AstBuilder calls#12716

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-01-refactor_parser_shorten_astbuilder_calls
Aug 1, 2025
Merged

refactor(parser): shorten AstBuilder calls#12716
graphite-app[bot] merged 1 commit intomainfrom
08-01-refactor_parser_shorten_astbuilder_calls

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 1, 2025

Pure refactor. Follow-on after #12698. Use AstBuilder::alloc_* methods to shorten code.

@github-actions github-actions bot added A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 1, 2025
Copy link
Member Author

overlookmotel commented Aug 1, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 1, 2025

CodSpeed Instrumentation Performance Report

Merging #12716 will not alter performance

Comparing 08-01-refactor_parser_shorten_astbuilder_calls (8a27974) with main (b25406f)

Summary

✅ 34 untouched benchmarks

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Aug 1, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 1, 2025

Merge activity

Pure refactor. Follow-on after #12698. Use `AstBuilder::alloc_*` methods to shorten code.
@graphite-app graphite-app bot force-pushed the 08-01-refactor_parser_shorten_astbuilder_calls branch from f7a5f41 to 8a27974 Compare August 1, 2025 11:08
@graphite-app graphite-app bot merged commit 8a27974 into main Aug 1, 2025
25 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 1, 2025
@graphite-app graphite-app bot deleted the 08-01-refactor_parser_shorten_astbuilder_calls branch August 1, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant