refactor(napi/oxlint): diagnostics communicate which rule via rule index, not rule ID by overlookmotel · Pull Request #12482 · oxc-project/oxc

overlookmotel · 2025-07-23T17:18:40Z

Related to #12437.

Diagnostics sent from JS to Rust specify which rule the diagnostic relates to via an index into external_rules, instead of the ExternalRuleId. This allows removing the loop over external_rules on Rust side to find the relevant rule.

overlookmotel · 2025-07-23T17:19:03Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-07-23T17:23:34Z

CodSpeed Instrumentation Performance Report

Merging #12482 will not alter performance

_{Comparing 07-23-refactor_napi_oxlint_diagnostics_communicate_which_rule_via_rule_index_not_rule_id (8c8c8bc) with main (515b473)¹}

Summary

✅ 34 untouched benchmarks

No successful run was found on main (69f8b63) during the generation of this report, so 515b473 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

crates/oxc_linter/src/external_plugin_store.rs

napi/oxlint2/src-js/index.js

graphite-app · 2025-07-24T11:10:46Z

Merge activity

Jul 24, 11:10 AM UTC: camc314 added this pull request to the Graphite merge queue.
Jul 24, 11:19 AM UTC: Merged by the Graphite merge queue.

…dex, not rule ID (#12482) Related to #12437. Diagnostics sent from JS to Rust specify which rule the diagnostic relates to via an index into `external_rules`, instead of the `ExternalRuleId`. This allows removing the loop over `external_rules` on Rust side to find the relevant rule.

## [1.9.0] - 2025-07-29 ### 💥 BREAKING CHANGES - 5a7e72a semantic: [**BREAKING**] `AstNodes::program` return `&Program` not `Option<&Program>` (#12515) (overlookmotel) ### 🚀 Features - 3489ce0 linter: Add `typescript-eslint/explicit-module-boundary-types` (#12402) (Don Isaac) ### 🐛 Bug Fixes - 0fd3e87 linter: Default options for `eslint/yoda` (#12540) (Sysix) - 724776f linter: Default options for `unicorn/switch-case-braces` (#12539) (Sysix) - fda45ea linter/promise/prefer-await-to-callbacks: False positive for `addEventListener` (#12537) (Copilot) - 1a710e3 linter/array-type: Fix more false negatives (#12501) (camc314) - 2b5bf98 linter: Consistent-function-scoping false positive with hoisted var declarations (#12523) (camc314) - cc19c8b vscode: Fix statusbar icon order (#12544) (Christian Fehmer) - 209d006 linter: Parse vue lang attribute without quotes (#12517) (Sysix) - 85a34ce linter/array-type: False negative with arrays in generic args (#12500) (camc314) - 98c1fbb linter/require-await: Improve async keyword detection in get_delete_span function (#12494) (camc314) - 7c75dba linter/require-await: Improve span calculation for object properties (#12490) (camc314) - 2b261cf linter/exhaustive-deps: False positive in exhaustive deps (#12471) (camc314) ### 🚜 Refactor - a696227 linter: Remove AstKind for SimpleAssignmentTarget (#12401) (Tyler Earls) - 7af38e1 napi/oxlint: Simplify `ExternalLinterLintFileCb` type (#12572) (overlookmotel) - 543fd53 napi/oxlint: Rename `run` to `lintFile` (#12567) (overlookmotel) - 0179c86 napi/oxlint: Reverse args of `ExternalLinter::new` (#12566) (overlookmotel) - 491c401 linter: Remove `#[must_use]` from `LintService::with_*` methods (#12560) (overlookmotel) - d44b0ac linter: Remove `Runner` trait (#12559) (overlookmotel) - bea652f linter: Add `vue` and `regex` to `BuiltinLintPlugins` (#12542) (Sysix) - aa9dd21 linter/no-eval: Get source type from `Semantic` (#12514) (overlookmotel) - 5c33fc7 diagnostics: Implement `Eq` and `Ord` for `InfoPosition` (#12505) (overlookmotel) - 8c8c8bc napi/oxlint: Diagnostics communicate which rule via rule index, not rule ID (#12482) (overlookmotel) - e2d9b4d fixer: Add Debug trait to PossibleFixes and Message structs (#12493) (camc314) - f0b1f0d napi/oxlint, napi/parser: Remove source length from `RawTransferMetadata` (#12483) (overlookmotel) - 7e4959a napi/oxlint: Rename `rules` to `ruleNames` (#12477) (overlookmotel) - 7a0da04 diagnostics: Remove Option wrapper from MPSC channel and sender field (#12467) (camc314) ### 🧪 Testing - 56468c7 linter/no-unused-private-class-members: Add more test cases (#12569) (camc314) - 191a164 linter/no-unused-private-class-members: Add more test cases (#12563) (camc314) - d31adcf linter: Improve sorting diagnostics (#12504) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jul 23, 2025

This was referenced Jul 23, 2025

fix(napi/oxlint): return diagnostics even if AST is not visited #12479

Merged

feat(napi/oxlint): add id to Context #12480

Merged

overlookmotel mentioned this pull request Jul 23, 2025

feat(napi/oxlint): add getFilename + getPhysicalFilename methods to Context #12481

Closed

overlookmotel marked this pull request as ready for review July 23, 2025 17:22

overlookmotel requested a review from camc314 as a code owner July 23, 2025 17:22

overlookmotel mentioned this pull request Jul 23, 2025

Linter plugins: Various changes #12437

Open

9 tasks

camc314 reviewed Jul 24, 2025

View reviewed changes

crates/oxc_linter/src/external_plugin_store.rs Outdated Show resolved Hide resolved

camc314 reviewed Jul 24, 2025

View reviewed changes

napi/oxlint2/src-js/index.js Show resolved Hide resolved

camc314 reviewed Jul 24, 2025

View reviewed changes

napi/oxlint2/src-js/index.js Show resolved Hide resolved

overlookmotel changed the base branch from 07-23-feat_napi_oxlint_add_more_file_path-related_apis_to_context_ to graphite-base/12482 July 24, 2025 10:59

overlookmotel force-pushed the graphite-base/12482 branch from f49acdb to 69f8b63 Compare July 24, 2025 10:59

overlookmotel force-pushed the 07-23-refactor_napi_oxlint_diagnostics_communicate_which_rule_via_rule_index_not_rule_id branch from 321c09f to 1f7cfe9 Compare July 24, 2025 10:59

overlookmotel changed the base branch from graphite-base/12482 to main July 24, 2025 10:59

overlookmotel mentioned this pull request Jul 24, 2025

feat(napi/oxlint): add filename property to Context #12497

Merged

overlookmotel requested a review from camc314 July 24, 2025 11:09

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jul 24, 2025

graphite-app bot force-pushed the 07-23-refactor_napi_oxlint_diagnostics_communicate_which_rule_via_rule_index_not_rule_id branch from 1f7cfe9 to 8c8c8bc Compare July 24, 2025 11:11

graphite-app bot merged commit 8c8c8bc into main Jul 24, 2025
24 checks passed

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 24, 2025

graphite-app bot deleted the 07-23-refactor_napi_oxlint_diagnostics_communicate_which_rule_via_rule_index_not_rule_id branch July 24, 2025 11:19

oxc-bot mentioned this pull request Jul 29, 2025

release(oxlint): v1.9.0 #12582

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

refactor(napi/oxlint): diagnostics communicate which rule via rule index, not rule ID#12482

refactor(napi/oxlint): diagnostics communicate which rule via rule index, not rule ID#12482
graphite-app[bot] merged 1 commit intomainfrom
07-23-refactor_napi_oxlint_diagnostics_communicate_which_rule_via_rule_index_not_rule_id

overlookmotel commented Jul 23, 2025 •

edited

Loading

Uh oh!

overlookmotel commented Jul 23, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Jul 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graphite-app bot commented Jul 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Comments

Conversation

overlookmotel commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #12482 will not alter performance

Summary

Footnotes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graphite-app bot commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

overlookmotel commented Jul 23, 2025 •

edited

Loading

overlookmotel commented Jul 23, 2025 •

edited

Loading

codspeed-hq bot commented Jul 23, 2025 •

edited

Loading

graphite-app bot commented Jul 24, 2025 •

edited

Loading