Skip to content

Comments

feat(linter): add typescript-eslint/explicit-module-boundary-types#12402

Merged
camc314 merged 15 commits intooxc-project:mainfrom
DonIsaac:don/feat/explicit-module-boundary-types
Jul 28, 2025
Merged

feat(linter): add typescript-eslint/explicit-module-boundary-types#12402
camc314 merged 15 commits intooxc-project:mainfrom
DonIsaac:don/feat/explicit-module-boundary-types

Conversation

@DonIsaac
Copy link
Contributor

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 19, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter A-ast Area - AST C-enhancement Category - New feature or request labels Jul 19, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 19, 2025

CodSpeed Instrumentation Performance Report

Merging #12402 will not alter performance

Comparing DonIsaac:don/feat/explicit-module-boundary-types (6cd3677) with main (7af38e1)

Summary

✅ 34 untouched benchmarks

@camc314 camc314 marked this pull request as ready for review July 24, 2025 12:09
@camc314 camc314 self-requested a review as a code owner July 24, 2025 12:09
@camc314
Copy link
Contributor

camc314 commented Jul 24, 2025

@DonIsaac do you mind taking a quick look at the changes I made? everything should be passing now.

Once you've taken a look, i'll re-review and merge.

Thank you!

@camc314 camc314 merged commit 3489ce0 into oxc-project:main Jul 28, 2025
24 checks passed
camc314 added a commit that referenced this pull request Jul 29, 2025
## [1.9.0] - 2025-07-29

### 💥 BREAKING CHANGES

- 5a7e72a semantic: [**BREAKING**] `AstNodes::program` return `&Program`
not `Option<&Program>` (#12515) (overlookmotel)

### 🚀 Features

- 3489ce0 linter: Add `typescript-eslint/explicit-module-boundary-types`
(#12402) (Don Isaac)

### 🐛 Bug Fixes

- 0fd3e87 linter: Default options for `eslint/yoda` (#12540) (Sysix)
- 724776f linter: Default options for `unicorn/switch-case-braces`
(#12539) (Sysix)
- fda45ea linter/promise/prefer-await-to-callbacks: False positive for
`addEventListener` (#12537) (Copilot)
- 1a710e3 linter/array-type: Fix more false negatives (#12501) (camc314)
- 2b5bf98 linter: Consistent-function-scoping false positive with
hoisted var declarations (#12523) (camc314)
- cc19c8b vscode: Fix statusbar icon order (#12544) (Christian Fehmer)
- 209d006 linter: Parse vue lang attribute without quotes (#12517)
(Sysix)
- 85a34ce linter/array-type: False negative with arrays in generic args
(#12500) (camc314)
- 98c1fbb linter/require-await: Improve async keyword detection in
get_delete_span function (#12494) (camc314)
- 7c75dba linter/require-await: Improve span calculation for object
properties (#12490) (camc314)
- 2b261cf linter/exhaustive-deps: False positive in exhaustive deps
(#12471) (camc314)

### 🚜 Refactor

- a696227 linter: Remove AstKind for SimpleAssignmentTarget (#12401)
(Tyler Earls)
- 7af38e1 napi/oxlint: Simplify `ExternalLinterLintFileCb` type (#12572)
(overlookmotel)
- 543fd53 napi/oxlint: Rename `run` to `lintFile` (#12567)
(overlookmotel)
- 0179c86 napi/oxlint: Reverse args of `ExternalLinter::new` (#12566)
(overlookmotel)
- 491c401 linter: Remove `#[must_use]` from `LintService::with_*`
methods (#12560) (overlookmotel)
- d44b0ac linter: Remove `Runner` trait (#12559) (overlookmotel)
- bea652f linter: Add `vue` and `regex` to `BuiltinLintPlugins` (#12542)
(Sysix)
- aa9dd21 linter/no-eval: Get source type from `Semantic` (#12514)
(overlookmotel)
- 5c33fc7 diagnostics: Implement `Eq` and `Ord` for `InfoPosition`
(#12505) (overlookmotel)
- 8c8c8bc napi/oxlint: Diagnostics communicate which rule via rule
index, not rule ID (#12482) (overlookmotel)
- e2d9b4d fixer: Add Debug trait to PossibleFixes and Message structs
(#12493) (camc314)
- f0b1f0d napi/oxlint, napi/parser: Remove source length from
`RawTransferMetadata` (#12483) (overlookmotel)
- 7e4959a napi/oxlint: Rename `rules` to `ruleNames` (#12477)
(overlookmotel)
- 7a0da04 diagnostics: Remove Option wrapper from MPSC channel and
sender field (#12467) (camc314)

### 🧪 Testing

- 56468c7 linter/no-unused-private-class-members: Add more test cases
(#12569) (camc314)
- 191a164 linter/no-unused-private-class-members: Add more test cases
(#12563) (camc314)
- d31adcf linter: Improve sorting diagnostics (#12504) (overlookmotel)

Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants