Skip to content

fix(linter): don't panic on TSNonNullExpression in unicorn/prefer-array-find#12400

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-19-fix_linter_don_t_panic_on_tsnonnullexpression_in_unicorn_prefer-array-find_
Jul 20, 2025
Merged

fix(linter): don't panic on TSNonNullExpression in unicorn/prefer-array-find#12400
graphite-app[bot] merged 1 commit intomainfrom
07-19-fix_linter_don_t_panic_on_tsnonnullexpression_in_unicorn_prefer-array-find_

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Jul 19, 2025

closes #12399

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Jul 19, 2025
Copy link
Member Author

Sysix commented Jul 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix force-pushed the 07-19-fix_linter_don_t_panic_on_tsnonnullexpression_in_unicorn_prefer-array-find_ branch from e9b061d to e4a015a Compare July 19, 2025 14:28
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 19, 2025

CodSpeed Instrumentation Performance Report

Merging #12400 will not alter performance

Comparing 07-19-fix_linter_don_t_panic_on_tsnonnullexpression_in_unicorn_prefer-array-find_ (05fba9b) with main (83dd31d)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (05fba9b) during the generation of this report, so 83dd31d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Sysix Sysix marked this pull request as ready for review July 19, 2025 14:31
@Sysix Sysix requested a review from camc314 as a code owner July 19, 2025 14:31
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 20, 2025
Copy link
Contributor

camc314 commented Jul 20, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 07-19-fix_linter_don_t_panic_on_tsnonnullexpression_in_unicorn_prefer-array-find_ branch from e4a015a to 05fba9b Compare July 20, 2025 21:04
@graphite-app graphite-app bot merged commit 05fba9b into main Jul 20, 2025
23 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 20, 2025
@graphite-app graphite-app bot deleted the 07-19-fix_linter_don_t_panic_on_tsnonnullexpression_in_unicorn_prefer-array-find_ branch July 20, 2025 21:08
camc314 added a commit that referenced this pull request Jul 22, 2025
## [1.8.0] - 2025-07-22

### 🚀 Features

- 6d2b549 napi/oxlint: Pass AST in buffer to JS (#12350) (overlookmotel)
- 14f0159 linter/exhaustive-deps: Add auto-fixer (#12354) (Don Isaac)

### 🐛 Bug Fixes

- 99e105f linter: Correct autofix in `unicorn/prefer-number-properties`
for Infinity (#12445) (yefan)
- 0b539e3 linter: `unicorn/catch-error-name` wasn't using the ignore
property (#12446) (Parbez)
- 05fba9b linter: Don't panic on `TSNonNullExpression` in
`unicorn/prefer-array-find` (#12400) (Sysix)
- 46e33d5 linter: Improve error handling in config file lookup (#12391)
(camc314)
- 4621872 linter: Parse second script block for `svelte` files (#12390)
(Sysix)
- fbe7eb4 linter/filename-case: Fix default config when no config is
provided (#12389) (camc314)
- fea9df4 linter: Report errors with the correct severity for custom
plugins (#12362) (camc314)
- 652c038 linter: Mark correctly enabled default rules for `--rules`
(#12163) (Sysix)
- eadc359 linter: Correct source text for vue files having script
attributes containig ">" char inside (#12375) (Sysix)
- 54d143a linter/exhaustive-deps: More descriptive messages for
always-rerender violations (#12336) (Don Isaac)
- dac4db9 linter/exhaustive-deps: Better diagnostics for missing
dependencies (#12337) (Don Isaac)
- 119d23a linter/prefer-array-flat-map: Error for `.flat(1.0)` (#12360)
(overlookmotel)

### 🚜 Refactor

- 2d9291c linter/prefer-number-properties: Simplify fixer logic (#12451)
(camc314)
- c5dff1e linter, napi/parser: Add `source_len` field to
`RawTransferMetadata` (#12383) (overlookmotel)
- 5e3b415 linter: Duplicate `RawTransferMetadata` in `oxc_linter` crate
(#12382) (overlookmotel)
- 773fd88 linter: Pass `&Allocator` into `Linter::run_external_rules`
(#12374) (overlookmotel)
- b10ed11 linter: Make unwrap unconditional (#12371) (overlookmotel)
- a0631d4 linter: Move running external rules into feature-gated
function (#12370) (overlookmotel)
- 4fc4e7c linter: Make feature gates for `oxlint2` feature consistent
(#12369) (overlookmotel)
- 50b1786 linter: Clarify usage of `Allocator` and `AllocatorGuard`
(#12332) (overlookmotel)
- 26d3a39 linter: Remove `ModuleContentOwner` abstraction (#12331)
(overlookmotel)

### 📚 Documentation

- 3c21d94 linter: Correct comment on `RawTransferMetadata2` type
(#12428) (overlookmotel)

Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic called Option::unwrap() on a None value in rules::unicorn::prefer_array_find

2 participants