Skip to content

refactor(semantic): streamline handling of no side effects for function #12221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jul 11, 2025
Merged

refactor(semantic): streamline handling of no side effects for function #12221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions crates/oxc_semantic/src/binder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,11 @@ impl<'a> Binder<'a> for Function<'a> {

let symbol_id = builder.declare_symbol(ident.span, &ident.name, includes, excludes);
ident.symbol_id.set(Some(symbol_id));

// Save `@__NO_SIDE_EFFECTS__`
if self.pure {
builder.scoping.no_side_effects.insert(symbol_id);
}
}

// Bind scope flags: GetAccessor | SetAccessor
Expand All @@ -173,13 +178,6 @@ impl<'a> Binder<'a> for Function<'a> {
PropertyKind::Init => {}
}
}

// Save `@__NO_SIDE_EFFECTS__`
if self.pure {
if let Some(symbol_id) = self.id.as_ref().and_then(|id| id.symbol_id.get()) {
builder.scoping.no_side_effects.insert(symbol_id);
}
}
}
}

Expand Down
Loading