refactor(semantic): streamline handling of no side effects for function#12221
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 11, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-semantic
Member
Merge activity
|
CodSpeed Instrumentation Performance ReportMerging #12221 will not alter performanceComparing Summary
|
…on (#12221) Pure refactor. `symbol_id` is declared earlier, so we don't need to get the symbol_id from the function again.
graphite-app
bot
force-pushed
the
07-10-fix_semantic_panics_when_function_is_the_part_of_ifstatement
branch
from
460ee24 to
e095e99
Compare
graphite-app
bot
force-pushed
the
07-11-refactor_semantic_streamline_handling_of_no_side_effects_for_function
branch
from
d6be980 to
8a7c9e8
Compare
Base automatically changed from
07-10-fix_semantic_panics_when_function_is_the_part_of_ifstatement
to
main
July 11, 2025 14:41
graphite-app
bot
deleted the
07-11-refactor_semantic_streamline_handling_of_no_side_effects_for_function
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor.
symbol_idis declared earlier, so we don't need to get the symbol_id from the function again.