perf(transformer/styled-components): pass Atom instead of Option<Atom>#12218
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 11, 2025
Conversation
This was referenced Jul 11, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-transformer
CodSpeed Instrumentation Performance ReportMerging #12218 will not alter performanceComparing Summary
|
Dunqing
approved these changes
Jul 11, 2025
Member
Merge activity
|
…tom>` (#12218) Small optimization. There's only one path leading to `create_object_property` where `value` can be `None`. Move `value.unwrap_or(Atom::from(""))` from `create_object_property` to the one place where `None` was previously created. This avoids creating an `Option::Some` on all the other paths, only to unwrap it again later. This removes a branch from `create_object_property`.
graphite-app
bot
force-pushed
the
07-11-refactor_transformer_styled-components_use_atom_everywhere
branch
from
8f29673 to
836bf9d
Compare
graphite-app
bot
force-pushed
the
07-11-perf_transformer_styled-components_pass_atom_instead_of_option_atom_
branch
from
e743157 to
242e721
Compare
Base automatically changed from
07-11-refactor_transformer_styled-components_use_atom_everywhere
to
main
July 11, 2025 15:37
graphite-app
bot
deleted the
07-11-perf_transformer_styled-components_pass_atom_instead_of_option_atom_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small optimization. There's only one path leading to
create_object_propertywherevaluecan beNone.Move
value.unwrap_or(Atom::from(""))fromcreate_object_propertyto the one place whereNonewas previously created. This avoids creating anOption::Someon all the other paths, only to unwrap it again later. This removes a branch fromcreate_object_property.