Skip to content

refactor(transformer/styled-components): store block name in arena#12216

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-11-refactor_transformer_styled-components_store_block_name_in_arena
Jul 11, 2025
Merged

refactor(transformer/styled-components): store block name in arena#12216
graphite-app[bot] merged 1 commit intomainfrom
07-11-refactor_transformer_styled-components_store_block_name_in_arena

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 11, 2025

In some circumstances, block_name can be inserted into AST in many places. So put it in arena, and reuse the same string over and over, rather than creating a new arena string each time.

Sorry @Dunqing! It was me that said store it as a String. I was wrong!

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jul 11, 2025
Copy link
Member Author

overlookmotel commented Jul 11, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 11, 2025

CodSpeed Instrumentation Performance Report

Merging #12216 will not alter performance

Comparing 07-11-refactor_transformer_styled-components_store_block_name_in_arena (0c08c37) with 07-11-refactor_transformer_styled-components_shorten_code (5fffa96)

Summary

✅ 34 untouched benchmarks

@Dunqing
Copy link
Member

Dunqing commented Jul 11, 2025

I thought I had misunderstood what data should have been stored in the arena all along —thank goodness you spotted I was correct here!

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jul 11, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 11, 2025

Merge activity

…12216)

In some circumstances, `block_name` can be inserted into AST in many places. So put it in arena, and reuse the same string over and over, rather than creating a new arena string each time.

Sorry @Dunqing! It was me that said store it as a `String`. I was wrong!
@graphite-app graphite-app bot force-pushed the 07-11-refactor_transformer_styled-components_shorten_code branch from f17088c to 5fffa96 Compare July 11, 2025 15:27
@graphite-app graphite-app bot force-pushed the 07-11-refactor_transformer_styled-components_store_block_name_in_arena branch from 8d00718 to 0c08c37 Compare July 11, 2025 15:27
Base automatically changed from 07-11-refactor_transformer_styled-components_shorten_code to main July 11, 2025 15:35
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 11, 2025
@graphite-app graphite-app bot merged commit 0c08c37 into main Jul 11, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 07-11-refactor_transformer_styled-components_store_block_name_in_arena branch July 11, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants