refactor(transformer/styled-components): store block name in arena#12216
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 11, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 11, 2025
CodSpeed Instrumentation Performance ReportMerging #12216 will not alter performanceComparing Summary
|
Member
|
I thought I had misunderstood what data should have been stored in the arena all along —thank goodness you spotted I was correct here! |
Dunqing
approved these changes
Jul 11, 2025
Contributor
Merge activity
|
f17088c to
5fffa96
Compare
8d00718 to
0c08c37
Compare
Base automatically changed from
07-11-refactor_transformer_styled-components_shorten_code
to
main
July 11, 2025 15:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

In some circumstances,
block_namecan be inserted into AST in many places. So put it in arena, and reuse the same string over and over, rather than creating a new arena string each time.Sorry @Dunqing! It was me that said store it as a
String. I was wrong!