feat(eslint-plugin-next): no-html-link-for-pages rule addition by TheCukitoDev · Pull Request #12194 · oxc-project/oxc

TheCukitoDev · 2025-07-10T14:20:27Z

Hello, i've succesfully added the rule next/no-html-link-for-pages rule addition to the oxc linter. It has now full nextjs linter support.

… plugin full compatibility and append it to rules.rs file

graphite-app · 2025-07-10T14:20:37Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

crates/oxc_linter/src/rules/nextjs/no_html_link_for_pages.rs

TheCukitoDev · 2025-07-10T15:48:05Z

Also, this PR closes issue #1929.

camc314

thank you!

codspeed-hq · 2025-07-11T09:33:09Z

CodSpeed Instrumentation Performance Report

Merging #12194 will not alter performance

_{Comparing TheCukitoDev:main (ce07ad8) with main (242e721)}

Summary

✅ 34 untouched benchmarks

TheCukitoDev · 2025-07-11T10:45:49Z

I'm trying to repair the errors. I'll update the PR ASAP. Thank you too😁

TheCukitoDev · 2025-07-11T11:15:31Z

Ok, i've found the error in the snapshot. I forgot to udpate it 😞 . I've only changed the 158 to 159 rules. I've tested it in my computer and it works perfectly. Thanks.

camc314 · 2025-07-11T12:16:58Z

I can't seem to push to your fork. Do you mind fixing the clippy error, then this can be merged

…_for_pages rule to solve clippy linting conflict

TheCukitoDev · 2025-07-11T13:26:29Z

Hello, i've changed the method and now compiles correctly.

crates/oxc_linter/src/rules/nextjs/no_html_link_for_pages.rs

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

TheCukitoDev · 2025-07-15T10:32:23Z

Hello, I've already submitted the changes. @camc314

## [1.7.0] - 2025-07-16 ### 🚀 Features - 5e428a4 linter/eslint-plugin-next: No-html-link-for-pages rule addition (#12194) (Gabriel Díaz Aguilera) - 9b14fbc ast: Add `ThisExpression` to `TSTypeName` (#12156) (Boshen) - c551b8f linter: Report diagnostics from custom plugins (#12219) (camc314) - d387729 linter: JS custom rules config (#12160) (camc314) - 152e59d napi/oxlint: Read source text into start of allocator (#12122) (overlookmotel) - bde1ef1 linter: Load custom JS plugins (#11980) (camc314) - d4ebd14 linter: Add `oxlint2`/`disable_oxlint2` feature flags (#12130) (camc314) - a4dae73 linter: Introduce `LintPlugins` to store builtin + custom plugins (#12117) (camc314) ### 🐛 Bug Fixes - 3f9a1f0 linter/no-unused-private-class-members: Fix false positive with nullish coalescing assignments (#12317) (camc314) - 47fad0e linter/no-empty-file: False positive with empty file with triple slash directive (#12293) (camc314) - 633ba30 linter: False positive with unknown plugins when unmatched eslint rule (#12285) (camc314) - 9720774 linter: Report implicit config parse errors (#12260) (Simon Buchan) - 1920c6b language_server: Respect the root `.oxlintrc.json` file for `ignorePatterns` (#12171) (Sysix) - 98708eb linter: Fix inconsistent behavior in `no-duplicate-imports` rule (#12192) (yefan) - 853d2bc linter, language_server: Correctly identify usage of `import` plugin (#12157) (overlookmotel) ### 🚜 Refactor - ee761de ast: Remove `AstKind` for `AssignmentTarget` (#12252) (Tyler Earls) - c68b607 ast: Rename `TemplateLiteral::quasi` to `TemplateLiteral::single_quasi` (#12266) (Dunqing) - 32c32af ast: Check whether there is a single `quasi` in `TemplateLiteral::quasi` (#12265) (Dunqing) - 8f6a1da linter/js-plugins: Use `u32` for IDs (#12243) (overlookmotel) - 36cd364 linter/js-plugins: Clean up code (#12242) (overlookmotel) - 8c02ebd linter/js-plugins: Rename `specifiers` to `paths` (#12241) (overlookmotel) - 3adaf98 linter: Simplify getting nodes count (#12239) (overlookmotel) - 6e54645 language_server: Store `LintService` instead of `Linter` (#12016) (Sysix) - 113cf8c linter: Move `LintServiceOptions.paths` to `LintService.with_paths` (#12015) (Sysix) - acfac68 oxlint: Adjust ignore patterns by counting bytes instead of chars (#12209) (Sysix) - 729b82b linter: Rename `plugin_name` to `plugin_specifier` (#12148) (overlookmotel) - 532b816 linter: Use `to_string` instead of `into` (#12147) (overlookmotel) - 89f2a69 linter: TODO comment (#12146) (overlookmotel) - f90d3e1 linter: Feature gate `load_external_plugin` by both `oxlint2` and `disable_oxlint2` features (#12141) (overlookmotel) - 12e4ec7 linter: Make `tokio` dependency optional (#12140) (overlookmotel) - 1d2eaca oxlint2: Introduce `force_test_reporter` feature for consistent graphical outputs (#12133) (camc314) - 8814c53 ast: Remove `AstKind` for `PropertyKey` (#12108) (camchenry) - 228cff5 semantic,linter: Assert that Program is always the first node (#12123) (Ulrich Stark) - e8e2a25 ast: Remove `AstKind` for `AssignmentTargetPattern` (#12105) (camchenry) - f7c675d linter: Rename `LintPlugins` to `BuiltinLintPlugins` (#12116) (camc314) - a9e5ec0 linter: Access plugins through config instead of storing directly (#12115) (camc314) - 9736a7f linter: Simplify `unicorn/require-post-message-target-origin` (#12110) (shulaoda) ### 📚 Documentation - 2e3db46 linter: Add missing backtick preventing website from building (#12113) (camc314) ### ⚡ Performance - d0f8b88 linter/js-plugins: Do not copy `Vec` (#12248) (overlookmotel) - 4284d19 linter/js-plugins: Use hashmap `Entry` API + remove temp `Vec` (#12247) (overlookmotel) - c7889c3 semantic,linter: Simplify implementation and uses of ancestors iterators (#12164) (Ulrich Stark) - f99959c linter: Move work out of loop (#12145) (overlookmotel) - 514d40c linter: Do not create `Resolver` unless required (#12142) (overlookmotel) - 7103527 linter/no-constructor-return: Optimize loop (#12138) (overlookmotel) ### 🧪 Testing - d1194e8 oxlint: Ignore test on windows (#12262) (camc314) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

TheCukitoDev added 2 commits July 10, 2025 14:01

feat(nextjs): add rule no_html_link_for_pages logic for nextjs eslint…

3628fb5

… plugin full compatibility and append it to rules.rs file

Move snap

1737598

TheCukitoDev requested a review from camc314 as a code owner July 10, 2025 14:20

github-actions bot added the A-linter Area - Linter label Jul 10, 2025

graphite-app bot reviewed Jul 10, 2025

View reviewed changes

crates/oxc_linter/src/rules/nextjs/no_html_link_for_pages.rs Show resolved Hide resolved

TheCukitoDev changed the title ~~eslint-plugin-next no-html-link-for-pages rule addition~~ feat(eslint-plugin-next): no-html-link-for-pages rule addition Jul 10, 2025

github-actions bot added the C-enhancement Category - New feature or request label Jul 10, 2025

camc314 approved these changes Jul 11, 2025

View reviewed changes

fix(snapshots): update rule count in snapshot for issue 11644

f3340e9

github-actions bot added the A-cli Area - CLI label Jul 11, 2025

TheCukitoDev requested a review from camc314 July 11, 2025 11:18

fix(nextjs): use is_some_and for href attribute check in no_html_link…

9c52531

…_for_pages rule to solve clippy linting conflict

graphite-app bot reviewed Jul 11, 2025

View reviewed changes

crates/oxc_linter/src/rules/nextjs/no_html_link_for_pages.rs Outdated Show resolved Hide resolved

TheCukitoDev and others added 3 commits July 11, 2025 15:37

Update crates/oxc_linter/src/rules/nextjs/no_html_link_for_pages.rs

98bea51

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

[autofix.ci] apply automated fixes

de99c7b

Merge branch 'main' into main

ce07ad8

camc314 merged commit 5e428a4 into oxc-project:main Jul 15, 2025
23 checks passed

oxc-bot mentioned this pull request Jul 16, 2025

release(oxlint): v1.7.0 #12326

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(eslint-plugin-next): no-html-link-for-pages rule addition#12194

feat(eslint-plugin-next): no-html-link-for-pages rule addition#12194
camc314 merged 7 commits intooxc-project:mainfrom
TheCukitoDev:main

TheCukitoDev commented Jul 10, 2025

Uh oh!

graphite-app bot commented Jul 10, 2025

Uh oh!

Uh oh!

TheCukitoDev commented Jul 10, 2025

Uh oh!

camc314 left a comment

Uh oh!

codspeed-hq bot commented Jul 11, 2025 •

edited

Loading

Uh oh!

TheCukitoDev commented Jul 11, 2025

Uh oh!

TheCukitoDev commented Jul 11, 2025

Uh oh!

camc314 commented Jul 11, 2025

Uh oh!

TheCukitoDev commented Jul 11, 2025

Uh oh!

Uh oh!

TheCukitoDev commented Jul 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

TheCukitoDev commented Jul 10, 2025

Uh oh!

graphite-app bot commented Jul 10, 2025

How to use the Graphite Merge Queue

Uh oh!

Uh oh!

TheCukitoDev commented Jul 10, 2025

Uh oh!

camc314 left a comment

Choose a reason for hiding this comment

Uh oh!

codspeed-hq bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #12194 will not alter performance

Summary

Uh oh!

TheCukitoDev commented Jul 11, 2025

Uh oh!

TheCukitoDev commented Jul 11, 2025

Uh oh!

camc314 commented Jul 11, 2025

Uh oh!

TheCukitoDev commented Jul 11, 2025

Uh oh!

Uh oh!

TheCukitoDev commented Jul 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codspeed-hq bot commented Jul 11, 2025 •

edited

Loading